16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

[Andrew Sackville-West]

Well 16690 breaks make check. 

meanwhile I discovered that src/engine/iso-currencies-to-c isn't
getting run. At least it looks that way because its supposed to update
iso-4217-currencies.c and it doesn't. That doesn't seem to be the
source of the failure but is something to note anyway. I did manually
run iso-currencies-to-c, saw that it appeared to update
iso-4217-currencies.c properly and make check still failed. :(

But interestingly, Derek reverted 16619 and that causes make check to
succeed. Seems odd to me that adjusting a currency would cause 16619
to cause a test to break. So maybe there is more going on here than
meets the eye. 

A


On Sun, Dec 23, 2007 at 07:09:04PM -0800, Andrew Sackville-West wrote:
> On Sun, Dec 23, 2007 at 08:33:10PM -0500, Derek Atkins wrote:
> > Quoting Andrew Sackville-West <andrew at swclan.homelinux.org>:
> >
> >> Well, I honestly don't know. Based on the political situation, I'd say
> >> it's highly likely that the old ones are still in circulation, but how
> >> many of those are being tracked in financial software?
> >>
> >> How does conversion handle historic data in a file? IOW, if I have
> >> txn's in the old currency predating the new currnecy and gnucash
> >> "converts" what happens to those old txns?
> >
> > It does an internal conversion.  EVERYTHING gets migrated over.
> > This is used when the currency is renamed or reissued.  Hence
> > the question of whether it really is a different currency or just
> > a reissue of the older one.
> 
> It's a reissue but its properties have changed (no longer subdivided
> into "puls" at 100 per afghani) so prior transactions could have had
> fractional amounts which don't exist for the new currency. Further the
> old afghani was converted into new afghanis at two distinct rates
> depending upon whose authority issued the currency (wacky!). Some were traded
> at 1000 old to 1 new while some were traded at 2000 old to 1
> new. Combining those two facts makes me think it should remain as two
> distict currencies, but I'm only learning here, so please feel free to
> tell me I'm wrong. ;)
> 
> Thanks
> 
> A



> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel


-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20071223/5c518318/attachment-0001.bin