16690 breaks `make check` [WAS Re: AUDIT: r16690 - gnucash/trunk/src/engine - Daniel Harding's update to Afghani currency. closes #504257]

[Andrew Sackville-West]

On Sun, Dec 23, 2007 at 11:19:42PM -0800, Andrew Sackville-West wrote:
> Well 16690 breaks make check. 
> 
> meanwhile I discovered that src/engine/iso-currencies-to-c isn't
> getting run. At least it looks that way because its supposed to update
> iso-4217-currencies.c and it doesn't. That doesn't seem to be the
> source of the failure but is something to note anyway. I did manually
> run iso-currencies-to-c, saw that it appeared to update
> iso-4217-currencies.c properly and make check still failed. :(

okay, ignore that. sorry, it does run properly.

> 
> But interestingly, Derek reverted 16619 and that causes make check to
> succeed. Seems odd to me that adjusting a currency would cause 16619
> to cause a test to break. So maybe there is more going on here than
> meets the eye. 

Somehow, the two lines in 16690 cause make check to fails. If you
delete either line (or jsut comment the out), it passes. Leave them
both in, it fails. I can't see what the heck would cause it.

And I still believe that it should be two currencies for reasons
stated below.  

I am baffled, so someone please advise. Should I revert 16690
altogether? just delete the line for the old currency so `make check`
passes or is something else going on here that this changeset is
somehow exposing. The fact that rolling back 16619 makes me think so. 

Also `make check` fails later in sx, but I don't have a clue about
that.

A

 
> On Sun, Dec 23, 2007 at 07:09:04PM -0800, Andrew Sackville-West wrote:
> > On Sun, Dec 23, 2007 at 08:33:10PM -0500, Derek Atkins wrote:
> > > Quoting Andrew Sackville-West <andrew at swclan.homelinux.org>:
> > >
> > >> Well, I honestly don't know. Based on the political situation, I'd say
> > >> it's highly likely that the old ones are still in circulation, but how
> > >> many of those are being tracked in financial software?
> > >>
> > >> How does conversion handle historic data in a file? IOW, if I have
> > >> txn's in the old currency predating the new currnecy and gnucash
> > >> "converts" what happens to those old txns?
> > >
> > > It does an internal conversion.  EVERYTHING gets migrated over.
> > > This is used when the currency is renamed or reissued.  Hence
> > > the question of whether it really is a different currency or just
> > > a reissue of the older one.
> > 
> > It's a reissue but its properties have changed (no longer subdivided
> > into "puls" at 100 per afghani) so prior transactions could have had
> > fractional amounts which don't exist for the new currency. Further the
> > old afghani was converted into new afghanis at two distinct rates
> > depending upon whose authority issued the currency (wacky!). Some were traded
> > at 1000 old to 1 new while some were traded at 2000 old to 1
> > new. Combining those two facts makes me think it should remain as two
> > distict currencies, but I'm only learning here, so please feel free to
> > tell me I'm wrong. ;)
> > 
> > Thanks
> > 
> > A
> 
> 
> 
> > _______________________________________________
> > gnucash-devel mailing list
> > gnucash-devel at gnucash.org
> > https://lists.gnucash.org/mailman/listinfo/gnucash-devel
> 
> 
> -- 



> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel


-- 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20071224/6e2e421b/attachment.bin