PO file typos, the more difficult ones (cash-flow.scm)

[Christian Stimming]

Am Montag, 24. Dezember 2007 12:45 schrieb Herbert Thoma:
> >> 26.
> >> #.src/report/standard-reports/cash-flow.scm
> >> #: ../intl-scm/guile-strings.c:1352
> >> #, c-format
> >> msgid "%s - %s to %s for"
> >>
> > I've just looked up for myself in the source: This is the title string of
> > the report page. The first %s is the report name (usually "Cash Flow").
> > The second and third %s is the starting and ending date of the period
> > covered by this report.
> >
> > I have no idea why this string ends with "for" and what is supposed to
> > show up after this. Anyone who has used this report?
>
> After "for" some account names are supposed to show up.
>
> The cash flow report title shows up like this:
>
> Cash Flow - <start-date> to <end-date> for <account(s)>

Then I guess the "for" isn't really needed. A simply colon should do as well, 
like so:
  Cash Flow - <start-date> to <end-date>: <account(s)>

This would be achieved by the patch below. @Herbert: Do you think this would 
be okay?

Christian

diff --git a/src/report/standard-reports/cash-flow.scm 
b/src/report/standard-re
ports/cash-flow.scm
index 24fea47..3e29961 100644
--- a/src/report/standard-reports/cash-flow.scm
+++ b/src/report/standard-reports/cash-flow.scm
@@ -192,9 +192,12 @@


     (gnc:html-document-set-title!
-     doc (sprintf #f (_ "%s - %s to %s for")
-                 (get-option gnc:pagename-general gnc:optname-reportname)
-                  (gnc-print-date from-date-tp) (gnc-print-date to-date-tp)))
+     doc (string-append
+         (get-option gnc:pagename-general gnc:optname-reportname)
+         " - "
+         (sprintf #f (_ "%s to %s")
+                  (gnc-print-date from-date-tp) (gnc-print-date to-date-tp))
+         ": "))


     ;; add subaccounts if requested