r16282 - gnucash/branches/csv-import - Fixed some bugs, attempted to get STF code working with goffice 0.2

Josh Sled jsled at asynchronous.org
Thu Jul 19 20:03:15 EDT 2007


Benjamin Sperisen <lasindi at cvs.gnucash.org> writes:
> Trac: http://svn.gnucash.org/trac/changeset/16282

> Modified: gnucash/branches/csv-import/src/import-export/csv/gnc-csv-import.c
> ===================================================================
> --- gnucash/branches/csv-import/src/import-export/csv/gnc-csv-import.c	2007-07-08 18:42:22 UTC (rev 16281)
> +++ gnucash/branches/csv-import/src/import-export/csv/gnc-csv-import.c	2007-07-08 20:21:49 UTC (rev 16282)
> @@ -751,13 +754,8 @@
>       * user gives up. */
>      while(!((parse_data->error_lines == NULL) || user_canceled))
>      {
> -      /* TODO remove printfs */
> -      printf("start %d %d\n", g_list_length(parse_data->transactions),
> -             g_list_length(parse_data->error_lines));
> -      gnc_csv_preview_errors(preview);
> -      user_canceled = gnc_parse_to_trans(parse_data, account, TRUE);
> -      printf("end %d %d\n", g_list_length(parse_data->transactions),
> -             g_list_length(parse_data->error_lines));

A good alternative to printf is
g_(debug|message|info|warning|critical|error).  They have the same
formatting/varags support as printf, but with conditional effect.  And with
our logging framework [1], they can be made visible at (the start of) runtime via
config, without re-compiling.

[1] http://cvs.gnucash.org/docs/HEAD/group__Logging.html

-- 
...jsled
http://asynchronous.org/ - a=jsled; b=asynchronous.org; echo ${a}@${b}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20070719/ed749218/attachment.bin 


More information about the gnucash-devel mailing list