Errors in several of the business reports

[Nigel Titley]

Andreas Köhler wrote:
> Hi,
> 
> Nigel Titley schrieb:
>> Nigel Titley wrote:
>>> Andreas Köhler wrote:
>>>> yeah, that one was missed in the GWrap -> Swig transition and got 
>>>> fixed by r15754.  Thanks for the report!  I guess we need thorough 
>>>> testing of all reports before releasing 2.2.  What else? :-)
>>> Thanks for the fix (I'll do a rebuild and retest tonight).
>>>
>>> I'll do a run through of at least all the business reports and try 
>>> and do the rest as well.
>>
>> Results of testing are so far:
>>
>> Business - Customer        OK
>> Business - Easy invoice        OK
>> Business - Employee        OK
>> Business - Fancy invoice    Fails
>> Business - Payable ageing    Fails
>> Business - Printable Invoice    OK
>> Business - Receivable Ageing    Fails
>> Business - Vendor report    OK
> 
> thanks!  Payable and Receivable Ageing Reports failed here too, see 
> r15757.  Fancy invoice works for me though.  May you give us a (guile) 
> stacktrace or steps how to reproduce the error?  That would help a lot.

In /opt/gnucash/share/gnucash/scm/report.scm:
  427: 27* (if template (let* # # # ...) #f)
  428: 28  (let* (# # # ...) (gnc:html-document-set-style-sheet! doc 
stylesheet) ...)
  430: 29* [reg-renderer #]
In unknown file:
    ?: 30  (letrec ((opt-val #)) (let* (# # # # ...) (letrec # # # ...)))
     ...
    ?: 31  (letrec ((add-order #)) (if (not #) (begin # # ...)) ...)
In 
/opt/gnucash/share/gnucash/guile-modules/gnucash/report/fancy-invoice.scm:
  786: 32* (if (not (null? invoice)) (let* (# # # ...) (set! table #) 
...) ...)
  787: 33  (let* (# # # ...) (set! table #) ...)
  791: 34* (set! table (make-entry-table invoice (gnc:report-options 
report-obj) ...))
  791: 35* [make-entry-table # #<procedure dispatch #> #<procedure 
add-order #> ...]
In unknown file:
    ?: 36  (letrec ((opt-val #)) (let (# # # # ...) (letrec # #)))
In 
/opt/gnucash/share/gnucash/guile-modules/gnucash/report/fancy-invoice.scm:
     ...
  568: 37  (let* (# # # ...) (gnc:html-table-set-col-headers! table #) ...)
  578: 38* [do-rows-with-subtotals # # # ...]
  470: 39  (if (null? entries) (begin # # # ...) (let* # # # ...))
  523: 40  (let* (# # # # ...) (if display-all-taxes # #) 
(value-collector # # #) ...)
  535: 41* (if display-all-taxes (let # #) (tax-collector # # #))
  536: 42  (let ((tax-list #)) (update-account-hash acct-hash tax-list))
In unknown file:
     ...
    ?: 43  (begin (f (car l)) (lp (cdr l)))
    ?: 44* [#<procedure #f (item)> #<swig-pointer GncAccountValue * 
82a0ab8>]
In 
/opt/gnucash/share/gnucash/guile-modules/gnucash/report/fancy-invoice.scm:
  158: 45  (let* ((acct #) (val #) (ref #)) (hash-set! hash acct (if ref 
# val)))
  158: 46* [car #<swig-pointer GncAccountValue * 82a0ab8>]
/opt/gnucash/share/gnucash/guile-modules/gnucash/report/fancy-invoice.scm:158:19: 
In procedure car in expression (car item):
/opt/gnucash/share/gnucash/guile-modules/gnucash/report/fancy-invoice.scm:158:19: 
Wrong type argument in position 1: #<swig-pointer GncAccountValue * 82a0ab8>
In /opt/gnucash/share/gnucash/scm/report.scm:
  427: 24* (if template (let* # # # ...) #f)
  428: 25  (let* (# # # ...) (gnc:html-document-set-style-sheet! doc 
stylesheet) ...)
  430: 26* [reg-renderer #]
In unknown file:
    ?: 27  (letrec ((opt-val #)) (let* (# # # # ...) (letrec # # # ...)))
     ...
    ?: 28  (letrec ((add-order #)) (if (not #) (begin # # ...)) ...)
In 
/opt/gnucash/share/gnucash/guile-modules/gnucash/report/fancy-invoice.scm:
  786: 29* (if (not (null? invoice)) (let* (# # # ...) (set! table #) 
...) ...)
  787: 30  (let* (# # # ...) (set! table #) ...)
  791: 31* (set! table (make-entry-table invoice (gnc:report-options 
report-obj) ...))
  791: 32* [make-entry-table # #<procedure dispatch #> #<procedure 
add-order #> ...]
In unknown file:
    ?: 33  (letrec ((opt-val #)) (let (# # # # ...) (letrec # #)))
In 
/opt/gnucash/share/gnucash/guile-modules/gnucash/report/fancy-invoice.scm:
     ...
  568: 34  (let* (# # # ...) (gnc:html-table-set-col-headers! table #) ...)
  578: 35* [do-rows-with-subtotals # # # ...]
  470: 36  (if (null? entries) (begin # # # ...) (let* # # # ...))
  523: 37  (let* (# # # # ...) (if display-all-taxes # #) 
(value-collector # # #) ...)
  535: 38* (if display-all-taxes (let # #) (tax-collector # # #))
  536: 39  (let ((tax-list #)) (update-account-hash acct-hash tax-list))
In unknown file:
     ...
    ?: 40  (begin (f (car l)) (lp (cdr l)))
    ?: 41* [#<procedure #f (item)> #<swig-pointer GncAccountValue * 
82a0ab8>]
In 
/opt/gnucash/share/gnucash/guile-modules/gnucash/report/fancy-invoice.scm:
  158: 42  (let* ((acct #) (val #) (ref #)) (hash-set! hash acct (if ref 
# val)))
  158: 43* [car #<swig-pointer GncAccountValue * 82a0ab8>]
/opt/gnucash/share/gnucash/guile-modules/gnucash/report/fancy-invoice.scm:158:19: 
In procedure car in expression (car item):
/opt/gnucash/share/gnucash/guile-modules/gnucash/report/fancy-invoice.scm:158:19: 
Wrong type argument in position 1: #<swig-pointer GncAccountValue * 82a0ab8>