goffice-0.4.0 available, but configure script doesn't recognize it

[Thomas Klausner]

On Sat, May 05, 2007 at 07:09:52PM -0400, Josh Sled wrote:
> It looks like a pretty trivial change to configure.in to look for a
> different package name/version of goffice, around line 1103.
> 
> I wonder why the package name changed, and if that implies it's not
> compatible.  Do you care to make the change, try it out and see if it
> still builds, if not runs?  The only place we make use of goffice is in
> the graphing.

I patched configure.in, it found goffice-0.4 and compiled fine.
Patch is attached.

While running autogen.sh, I had lots of warnings of the kind
..../Makefile.am:3: `:='-style assignments are not portable
I'm using automake-1.10.

I'll also attach another patch I had lying around to make a format
string work on NetBSD-4.99.19/amd64 (by adding casts).

Cheers,
 Thomas
-------------- next part --------------
Index: configure.in
===================================================================
--- configure.in	(revision 16090)
+++ configure.in	(working copy)
@@ -1103,9 +1103,11 @@
     AC_SUBST(GLADE_CFLAGS)
     AC_SUBST(GLADE_LIBS)
 
-    PKG_CHECK_MODULES(GOFFICE, libgoffice-0.3 >= 0.3.0, [], [
-      PKG_CHECK_MODULES(GOFFICE, libgoffice-1 >= 0.0.4, [], [
-        AC_MSG_ERROR([Cannot find libgoffice.])
+    PKG_CHECK_MODULES(GOFFICE, libgoffice-0.4 >= 0.4.0, [], [
+      PKG_CHECK_MODULES(GOFFICE, libgoffice-0.3 >= 0.3.0, [], [
+        PKG_CHECK_MODULES(GOFFICE, libgoffice-1 >= 0.0.4, [], [
+          AC_MSG_ERROR([Cannot find libgoffice.])
+        ])
       ])
     ])
     AS_SCRUB_INCLUDE(GOFFICE_CFLAGS)
-------------- next part --------------
Index: src/gnome/druid-acct-period.c
===================================================================
--- src/gnome/druid-acct-period.c	(revision 16090)
+++ src/gnome/druid-acct-period.c	(working copy)
@@ -337,7 +337,7 @@
    * we may have closed books since last time. */
   info->earliest = get_earliest_in_book (gnc_get_current_book());
   info->earliest_str = qof_print_date(info->earliest); 
-  PINFO ("date of earliest is %ld %s", info->earliest, ctime (&info->earliest));
+  PINFO ("date of earliest is %ld %s", (long)info->earliest, ctime (&info->earliest));
 
   prepare_remarks (info);
 }
@@ -534,7 +534,7 @@
   info->earliest = get_earliest_in_book (gnc_get_current_book());
   info->earliest_str = qof_print_date(info->earliest); 
   PINFO ("date of earliest transaction is %ld %s", 
-                  info->earliest, ctime (&info->earliest));
+                  (long)info->earliest, ctime (&info->earliest));
 
   g_date_clear (&info->closing_date, 1);
   g_date_set_time_t (&info->closing_date, info->earliest);