[patch] Fixes for commodity debug logging
Andreas Köhler
andi5.py at gmx.net
Sat Nov 24 10:34:08 EST 2007
Hi Daniel,
Am Mittwoch, den 21.11.2007, 21:11 +0430 schrieb Daniel Harding:
> When adding gnc.commodity=debug to log.conf, a few problems result,
> which this patch attempts to fix.
>
> A few functions (gnc_quote_source_get_type, gnc_quote_source_get_index,
> gnc_quote_source_get_supported) called the ENTER macro when starting but
> called the DEBUG macro when returning. Because these ENTER calls had no
> matching LEAVE, the indentation in the log file would become messed up.
> This patch fixes that problem by changing those DEBUG macros to LEAVE
> macros.
>
> More seriously, gnucash would crash when editing a commodity whose quote
> source timezone is set to local time. In that case
> gnc_commodity_set_quote_tz is called with a NULL tz parameter.
> However, the ENTER macro would always attempt to dereference tz to print
> it, resulting a crash. This patch fixes that problem changing the macro
> to use the string "(null)" in the case that tz is NULL.
>
> I have not yet filed bugs on these issues. If that would be helpful I
> can do so.
thanks a lot! Your ticket is
http://bugzilla.gnome.org/show_bug.cgi?id=499360 :-D
-- andi5
More information about the gnucash-devel
mailing list