html-acct-table patch
Christian Stimming
stimming at tuhh.de
Fri Oct 26 15:46:03 EDT 2007
Hi Andrew,
thanks a lot for working on this! I now gave it a try, and your results are
really impressive. The income statement, which currently takes ~45 seconds,
which means it is unusable, is now finished in 10 seconds, which is at least
somehow usable.
http://bugzilla.gnome.org/show_bug.cgi?id=488001
I'd like to apply that patch, however:
Am Dienstag, 16. Oktober 2007 23:11 schrieb Andrew Sackville-West:
> ps. there's a lot of garbage in the patch due to shuffling stuff
> around. Are there ways to fix this up besides manually picking through
> the file? and I left a lot of my working comments in, should I kill
> those and resubmit?
Do you check "svn diff" often? In principle your patch is fine; however, I'd
like to ask to clean up the comments a bit. In particular, some of the
patch's comments obviously contain remarks from when you started the work and
then additional remarks from when you ended it. I'd like to ask to simply
delete those old comments of you and only summarize what you know at this
point in time (when submitting the patch). I think this will make your patch
an even greater value for this improvement in gnucash. Is this possible?
Thanks a lot.
Christian
More information about the gnucash-devel
mailing list