ajswest at mindspring.com
Sat Oct 27 19:27:29 EDT 2007
On Fri, Oct 26, 2007 at 09:46:03PM +0200, Christian Stimming wrote:
> Hi Andrew,
> thanks a lot for working on this! I now gave it a try, and your results are
> really impressive. The income statement, which currently takes ~45 seconds,
> which means it is unusable, is now finished in 10 seconds, which is at least
> somehow usable.
Imagine how happy I am with my main data file taking *forever*
(literally several minutes) to run a basic income statement. Plus
several of my regularly used custom reports are based on
income-statement as well. I can tell you its horrible. Especially
since it pegs my cpu the whole time. awful.
I know there is more work to be done on this report, but I'm so
pleased with the current improvement, I figure its good to get this
committed and (hopefully) backported.
Its important to note too that I don't really make use of the other
reports that rely on this code and so although I'm very confidant that
this patch returns the same results as the previous code, I can't
guarantee it. I did run some tests and to my eye it looked
good. Also, I didn't change any of the actual logic for calculating
the results, just replaced repeated account totalling with a one-time
pass of totalling needed accounts and cacheing that data for later
use, hence my confidence that the output is the same.
> I'd like to apply that patch, however:
> Do you check "svn diff" often?
not really. :) I do it all at once at the end...
> In principle your patch is fine; however, I'd
> like to ask to clean up the comments a bit [...] Is this possible?
absolutely. I expected as much and that's why I asked. Probably should
have just done it.
> Thanks a lot.
happy to help :)
I'll send a revised patch soon.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
Url : http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20071027/7236dfc8/attachment.bin
More information about the gnucash-devel