Fwd: GnuCash 2.2.x and advanced-report-sorted

[Derek Atkins]

Hi,

A few comments..

First, nice job, and thank you.
Second..  you don't need to change the name of the report.  We should keep
the same name, even though you're adding a new function.  This way people
with existing report configuration will get the new report functionality
automagically.
Third.. You should base the report on the one in 2.2.x (or SVN trunk),
not 1.8.  1.8 is two major revisions behind and, well, there've been
lots of changes and bugfixes that would get re-introduced by reverting
to 1.8
Fourth.. You should try to reduce the white-space changes; it makes
your changes harder to read and audit.  Worst case you could just
send in a diff ignoring white-space changes (see below).

So far it looks pretty good...  Any chance you could make sure the
report is based on 2.2 and send in a patch without whitespace changes?
You can use "svn diff -x -b" to ignore white space changes.

Thanks!

-derek

Quoting Johan van Oostrum <jo.vanoost at wanadoo.nl>:

> Begin doorgestuurd bericht:
>> Van: Johan van Oostrum <jo.vanoost at wanadoo.nl>
>> Datum: 11 september 2007 22:42:35 GMT+02:00
>> Aan: Derek Atkins <warlord at MIT.EDU>
>> Onderwerp: Antw.: GnuCash 2.2.x and advanced-report-sorted
>>
>> Op 11-sep-2007, om 15:37 heeft Derek Atkins het volgende geschreven:
>>
>>> Hi,
>>> What is the difference between this report and the existing
>>> "advanced portfolio" report?
>> Functional change: sortcolumn option added
>> Code is (more or less) restructured to allow for easy use of sort
>>
>>> Would it be worthwhile to combine
>>> them into a single report where the "sorting" part is just
>>> a report option?  Or are the reports so significantly
>>> different that merging them would be nearly impossible?
>> Excellent suggestion. I created a (my first :-) svn diff today.
>>
>>> If you can combine them into a single report with an option
>>> to add sorting, sending in a patch (svn diff) would be a good
>>> way to get it applied to SVN for the next release....
>> Attached you find the diff.
>> Notes
>> - name changed to advanced-portfolio-sorted
>> - it is an update of the GnuCash 1.8.x advanced report, not the new  
>> report that is packed with GC 2.2.x.
>>
>



-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available