Plot details - barchart reports

[Davide Imbeni]

Hi again,

I started to look into goffice, and dealt with the grid option, as a start
(easy things first...).

I think I got it working in a pretty enough way (for me). I added a few
lines in src/gnome-utils/gnc-html-graph-gog.c that actually draw the
y-major-grid on some grayed background, and added the relevant option
"Background Grid" in the Display Tab of the barchart report.
All in all, changed (as few lines as possible)
src/gnome-utils/gnc-html-graph-gog.c
src/report/report-system/html-barchart.scm
src/report/report-system/report-system.scm
src/report/standard-reports/category-barchart.scm

Now the questions:

How do I submit this changes to you, so as to get feedback/comments and
eventually, hopefully, have this little piece of code included in the trunk?
Please assume very basic knowledge of svn and diff...

Since I modified some gnucash code rather than creating a custom report, if
I don't get them incorporated I will loose my changes when gnucash evolves,
right?

BTW, I was working on r16930, downloaded via SVN.

Thanks

Davide



On Feb 7, 2008 6:32 PM, Davide Imbeni <davide.imbeni at gmail.com> wrote:

> Thanks for your indications.
> I will start to work on it and report as soon as I have something ready,
> or (more likely) additional doubts.
> As I said, I will first have to learn A LOT, so don't expect fast
> patches...
>
> Thank you
>
> Davide
>
>
>
> On Feb 7, 2008 6:08 PM, Josh Sled <jsled at asynchronous.org> wrote:
>
> > "Davide Imbeni" <davide.imbeni at gmail.com> writes:
> > > I would like to change slightly the appearance of the plots in
> > bar-chart
> > > reports.
> > > As it is now it's a bit difficult to get an idea of the level of the
> > bars (a
> > > part from the first one on the left), so I would like to add a grid to
> > the
> > > plot or, even better, have the actual numeric values visible (e.g.
> > when
> > > clicking on the corresponding bar, or when pointing it without
> > clicking, or
> > > even as a label close to it)
> >
> > These things would be provided by modifying how we call libgoffice,
> > which
> > provides the actual plotting.  The primary binding code between gnucash
> > and
> > goffice is in src/gnome-utils/gnc-html-graph-gog.c.
> >
> > The interface between the reports and that code is through a couple of
> > levels…
> >
> > The report (scm code) will emit an <object> tag with <param> tags for
> > the
> > various parameters.  See src/report/report-system/html-barchart.scm.
> >
> > GtkHtml is configured for <object> tags (with a particular class-id) to
> > be
> > handled by the aforementioned gnc-html-graph-gog code.  It then parses
> > the
> > params/data, and converts it into goffice's interface, and renders the
> > report
> > into a pixmap.  The pixmap is then returned to GtkHtml as the rendering
> > of
> > the <object> tag.
> >
> > > I don't know anything about scheme, guile, and extremely little about
> > html,
> > > and before continuing my research, I would like to get directions and
> > > suggestions from the experts.
> > >
> > > Where to start from? Do I have to dig into scheme? Shall I create a
> > custom
> > > report or change something in the stylesheet?
> >
> > - Make sure you know what's supported by goffice, and the details of
> > what it
> >  needs (for, say, labels on chart segments).
> > - Modify the pie/bar-chart generator code for those new parameters.
> > - Modify the gnc-html-graph-gog code for those new parameters.
> > - Modify the reports to use the new pie/bar-chart generator code.
> >
> >
> > We're here and happy to help if you have any questions.
> >
> > --
> > ...jsled
> > http://asynchronous.org/ - a=jsled; b=asynchronous.org; echo ${a}@${b}
> >
>
>