PERLINC in gnc-fq-*

Derek Atkins warlord at MIT.EDU
Thu Dec 10 16:03:33 EST 2009


John,

John Ralls <jralls at ceridwen.us> writes:

> So I've got a changeset ready to check in which removes the use lib
> line and changes the configurable shebang to /usr/bin/perl -w in each
> of gnc-fq-check, gnc-fq-helper, and gnc-fq-update; since there's no
> need to plug in anything anymore, those are renamed from their
> respective *.in. Makefile.in is adjusted accordingly.

I object to the second part.  You should leave the "Check for PERL"
command and allow the --with-perl=XXX or AC_PATH_PROG(PERL, perl).
I think it's a bad idea to assume that perl will be in /usr/bin/

> For configure.in I've removed the PERLINC section. I've also removed
> the configurable perl section; as far as I can tell only intltool uses
> perl and it has its own perl invocation variable.
>
> If there are no objections, I'll check this into trunk.

Consider this an objection to removing the configurable location of the
perl binary.  I think it's perfectly find to remove the PERLLIB
stuff, but the shebang path should remain be configurable.

> Regards,
> John Ralls

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available


More information about the gnucash-devel mailing list