PERLINC in gnc-fq-*

John Ralls jralls at ceridwen.us
Thu Dec 10 16:54:01 EST 2009


On Dec 10, 2009, at 1:03 PM, Derek Atkins wrote:

> John,
> 
> John Ralls <jralls at ceridwen.us> writes:
> 
>> So I've got a changeset ready to check in which removes the use lib
>> line and changes the configurable shebang to /usr/bin/perl -w in each
>> of gnc-fq-check, gnc-fq-helper, and gnc-fq-update; since there's no
>> need to plug in anything anymore, those are renamed from their
>> respective *.in. Makefile.in is adjusted accordingly.
> 
> I object to the second part.  You should leave the "Check for PERL"
> command and allow the --with-perl=XXX or AC_PATH_PROG(PERL, perl).
> I think it's a bad idea to assume that perl will be in /usr/bin/
> 
>> For configure.in I've removed the PERLINC section. I've also removed
>> the configurable perl section; as far as I can tell only intltool uses
>> perl and it has its own perl invocation variable.
>> 
>> If there are no objections, I'll check this into trunk.
> 
> Consider this an objection to removing the configurable location of the
> perl binary.  I think it's perfectly find to remove the PERLLIB
> stuff, but the shebang path should remain be configurable.

OK.

Regards,
John Ralls



More information about the gnucash-devel mailing list