r18103 - gnucash/trunk/src - Fix bug #584819: Company name is not shown by default on some reports. Patch by Chris Dennis.

[Phil Longstaff]

OK.  I'll remove it.  You're right - the dependency is the wrong way.  What we really need is a mechanism so that other subsystems can contribute pieces to the standard reports.

Phil



________________________________
From: Derek Atkins <warlord at MIT.EDU>
To: gnucash-devel at gnucash.org
Sent: Friday, June 5, 2009 8:51:20 AM
Subject: Re: r18103 - gnucash/trunk/src - Fix bug #584819: Company name is not shown by default on some reports. Patch by Chris Dennis.

Phil,

This patch is bad.

Standard Reports cannot depend on Business objects or Functions.
The business code is an optional subsystem.   So, you cannot
depend on the gnc:company-info procedure existing.

-derek

Phil Longstaff <plongstaff at code.gnucash.org> writes:

> Author: plongstaff
> Date: 2009-06-04 17:16:01 -0400 (Thu, 04 Jun 2009)
> New Revision: 18103
> Trac: http://svn.gnucash.org/trac/changeset/18103
>
> Modified:
>    gnucash/trunk/src/business/business-utils/business-utils.scm
>    gnucash/trunk/src/report/standard-reports/balance-sheet.scm
>    gnucash/trunk/src/report/standard-reports/budget-balance-sheet.scm
>    gnucash/trunk/src/report/standard-reports/budget-income-statement.scm
>    gnucash/trunk/src/report/standard-reports/equity-statement.scm
>    gnucash/trunk/src/report/standard-reports/income-statement.scm
>    gnucash/trunk/src/report/standard-reports/trial-balance.scm
> Log:
> Fix bug #584819: Company name is not shown by default on some reports.  Patch by Chris Dennis.
>
>
> _______________________________________________
> gnucash-patches mailing list
> gnucash-patches at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches
>
>

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
      warlord at MIT.EDU                        PGP key available
_______________________________________________
gnucash-devel mailing list
gnucash-devel at gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel