Or maybe not? German tax report should be disabled altogether (Re: [PATCH] - bug #554394 - Income Tax Enhancements - missing German patches attached)

Christian Stimming stimming at tuhh.de
Wed Nov 11 15:58:28 EST 2009


Dear Alex,

Am Mittwoch, 11. November 2009 schrieb J. Alex Aycinena:
> >> If you want to remove it, of course go ahead and do so. But the
> >> easiest thing (i.e., least amount of work for you) might be to just go
> >> ahead and apply my patches - the German version of taxes will work no
> >> better, but no worse, than before.
> >
> > Ok, thanks a lot for this patch. I've applied this to SVN now, r18409.
> > Thank you very much!
> >
> > Christian
> 
> Thanks for applying this but this patch for
> 'gnucash/trunk/src/tax/us/txf-de_DE.scm' will only work if you also
> apply the other patches as well:
> 
> the patch file I sent in on Nov 1 (which included
> 'src/engine/Account.c', 'src/engine/Account.h',

oh, sorry, I missed this part. However, the Nov 1 patch was causing compile 
errors (answered in separate mail).

Once you have an update of the first patch, I would propose to submit all 
changes in one single patch file. As you can see, I already got lost by three 
patches which depend on each other. It is usually easier if people submit 
something which can be applied "as-is" against SVN, or maybe (e.g. with git-
svn) in each mail the full series of patches.

Regards,

Christian


More information about the gnucash-devel mailing list