Patches for compile errors/warnings
Matt Lavin
matt.lavin at gmail.com
Mon Oct 26 16:43:18 EDT 2009
The first patch's main content was:
- return (*((guint *) guid->data));
+ return guid->data[0];
That was the real compile error. I removed the two static functions because they were functional duplicates of existing
code and I thought it would be better to reduce code duplication than to fix the same compiler error in two spots. Of
course, I didn't explain that and I should have. The duplicate methods could be added back if they are needed for a
reason I overlooked.
On Mon, 2009-10-26 at 21:38 +0100, Christian Stimming wrote:
> Am Donnerstag, 22. Oktober 2009 02:00 schrieb Matt Lavin:
> > I recently fetched the latest gnucash SVN source and tried to compile it
> > on a Ubuntu 9.10 (Karmic) machine. I ran into a couple of compiler
> > warnings and thought I'd send my patches so other people don't have to
> > make the same fixes.
>
> Thanks a lot. I've applied the second
> src/import-export/gnc-import-format-gnome.c already to SVN.
>
> As for the first: Can you briefly explain why the removal of the two static
> functions in src/libqof/qof/qofid.c solved a compiler issue? I didn't see the
> immediate reason for this.
>
> Regards,
>
> Christian
More information about the gnucash-devel
mailing list