Patches for compile errors/warnings

Phil Longstaff plongstaff at rogers.com
Mon Oct 26 18:54:31 EDT 2009


On October 26, 2009 04:43:18 pm Matt Lavin wrote:
> The first patch's main content was:
>
> -        return (*((guint *) guid->data));
> +        return guid->data[0];
>
> That was the real compile error.  I removed the two static functions
> because they were functional duplicates of existing code and I thought it
> would be better to reduce code duplication than to fix the same compiler
> error in two spots.  Of course, I didn't explain that and I should have. 
> The duplicate methods could be added back if they are needed for a reason I
> overlooked.

Won't that change the return value.  Old value: contents of the first 4 bytes 
of data.  New value: contents of the first 1 byte.

Phil


More information about the gnucash-devel mailing list