Patches for compile errors/warnings

Matt Lavin matt.lavin at gmail.com
Tue Oct 27 08:17:07 EDT 2009


You are right.  The new version of the code isn't quite right.  I'll
send an updated patch tonight.

On Mon, 2009-10-26 at 18:54 -0400, Phil Longstaff wrote:
> On October 26, 2009 04:43:18 pm Matt Lavin wrote:
> > The first patch's main content was:
> >
> > -        return (*((guint *) guid->data));
> > +        return guid->data[0];
> >
> > That was the real compile error.  I removed the two static functions
> > because they were functional duplicates of existing code and I thought it
> > would be better to reduce code duplication than to fix the same compiler
> > error in two spots.  Of course, I didn't explain that and I should have. 
> > The duplicate methods could be added back if they are needed for a reason I
> > overlooked.
> 
> Won't that change the return value.  Old value: contents of the first 4 bytes 
> of data.  New value: contents of the first 1 byte.
> 
> Phil
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel



More information about the gnucash-devel mailing list