Patch Re: Bug 625193 To move utils to core

[Mike Evans]

On Monday August 23 2010 18:42:40 Geert Janssens wrote:
> On Monday 23 August 2010, Mike Evans wrote:
> > On Tuesday August 17 2010 20:54:42 Christian Stimming wrote:
> > > Am Monday 16 August 2010 schrieb Mike Evans:
> > > > I've attached a patch to move utils.c utils.h to src/engine as
> > 
> > Attached is a patch to; add vendor search, to python bindings and
> > refactors files gncIDSearch.c/h with vendor search.  Both patch files
> > need to be
> > 
> >  applied.
> 
> Mike,
> 
> I'm not too experienced in C coding, but I wonder if it's not cleaner to
> define your general search function with an additional type parameter
> instead of globally declaring a type variable.
> 
> I don't find many global variable declarations in GnuCash unless they are
> static.
> 
> So my feeling is this may not be the best thing to do. Others can correct
> me if that's totally bogus though.
> 
> Geert
I had a nagging feeling that wasn't the ideal thing to do.  It's good to get 
another opinion.  I'll look at a better way.
Mike E


-- 
GPG Key: 1024D/050895C2
Keyserver: http://pgp.mit.edu/          
Search String: 0x050895C2