r18581 - gnucash/trunk - Bug #607522: Add ADDRESS to check printing

Jan Arne Petersen jap at gnome.org
Mon Feb 1 16:04:06 EST 2010


Hi,

On 02/01/2010 06:51 PM, Derek Atkins wrote:
> 
>> Attached a patch to fix that bug (and simplifies checks/Makefile.am)
>>
>> Best regards,
>> Jan Arne Petersen
>>
>>
>> diff --git a/checks/Makefile.am b/checks/Makefile.am
>> index cd5492a..e786bc7 100644
>> --- a/checks/Makefile.am
>> +++ b/checks/Makefile.am
>> @@ -2,24 +2,15 @@
>>  checksdir = ${GNC_CHECKS_DIR}
>>  
>>  if HAVE_GTK_2_10
>> -checks_DATA = \
>> +dist_checks_DATA = \
>>  	deluxe.chk \
>>  	liberty.chk \
>>  	quicken.chk \
>>  	voucher.chk \
>>  	quicken_wallet.chk
>>  else
>> -checks_DATA = \
>> +dist_checks_DATA = \
>>  	gnomeprint/deluxe.chk \
>>  	gnomeprint/quicken.chk \
>>  	gnomeprint/quicken_wallet.chk
>>  endif
>> -
>> -EXTRA_DIST = \
>> -	deluxe.chk \
>> -	liberty.chk \
>> -	quicken.chk \
>> -	quicken_wallet.chk \
>> -	gnomeprint/deluxe.chk \
>> -	gnomeprint/quicken.chk \
>> -	gnomeprint/quicken_wallet.chk
> 
> This patch is bad.  It breaks EXTRA_DIST so what you distribute is based
> on what Gtk version you have.  Bad Bad Bad!  you must always distribute
> all the check files, not just the check files you personally need!

That is not true. The above Makefile.am distributes all check files. See
http://www.gnu.org/software/hello/manual/automake/Conditional-Sources.html#Conditional-Sources

Best regards,
Jan Arne Petersen


More information about the gnucash-devel mailing list