Could you set 'svn:eol-style' to 'LF' for 'packaging/win32/*.sh'?

[Derek Atkins]

Hi,

Tao Wang <dancefire at gmail.com> writes:

> Hi,
>
> I'm adding themes and theme engines to Gnucash on Windows. Some error
> messages always occured during the patching. And then I found it's
> end-of-line problems stop me.
>
> The *.sh files do not share same svn:eol-style, some of them are set to
> 'LF', some set to 'native' which is 'CRLF' on Windows, the rest are not set
> svn:eol-style.Both setting them to 'LF' or leave them unset works for
> patching. At least, they should be shared same 'svn:eol-style'. Because, set
> them to 'LF' will not stop them running by 'bash' on Windows. So, I suggest
> set them to 'LF'. Thanks.

Are you doing your work on Windows or on Linux?   IMHO all scripts
should be set to eol-style native because then local editing on the
local system will do the right thing..  Although if you're doing your
work on a Windows system and then creating a patch, yes, it's sort of
going to expect the patch to be applied on Windows.

However I believe that changing the line-ending to LF would
be.. inappropriate.  It would make editing on Windows harder, and your
patches will most likely still have CRLF in them!

It's pretty easy to strip out CRLF from your patches using 'tr'.

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available