Could you set 'svn:eol-style' to 'LF' for 'packaging/win32/*.sh'?

[Tao Wang]

At least, let those files share same 'svn:eol-style'. I'm working on
Windows, however, it's free for my editor, 'notepad++', to convert the file
eol to 'LF' or 'CRLF'.

I am not sure how tolerance for eol of the mingw version of patch tools.
When I do the patching, if the some files are 'CRLF', and some files are
'LF', and my patch is 'CRLF', then there is always warning in the patching
for 'stripping CR', and sometimes, it failed for some files. I noticed, if
my patch is 'LF', then the files with eol 'CRLF' are failed to patch. If I
convert all files and my patch to 'LF', then there is no error or warning,
the patching is quite and smooth. So, I think set those '*.sh' to 'LF' would
helpful.

Anyway, I will try more about the eol-style tolerance for patching later.


On Thu, Jun 3, 2010 at 12:47 AM, Derek Atkins <warlord at mit.edu> wrote:

> Hi,
>
> Tao Wang <dancefire at gmail.com> writes:
>
> > Hi,
> >
> > I'm adding themes and theme engines to Gnucash on Windows. Some error
> > messages always occured during the patching. And then I found it's
> > end-of-line problems stop me.
> >
> > The *.sh files do not share same svn:eol-style, some of them are set to
> > 'LF', some set to 'native' which is 'CRLF' on Windows, the rest are not
> set
> > svn:eol-style.Both setting them to 'LF' or leave them unset works for
> > patching. At least, they should be shared same 'svn:eol-style'. Because,
> set
> > them to 'LF' will not stop them running by 'bash' on Windows. So, I
> suggest
> > set them to 'LF'. Thanks.
>
> Are you doing your work on Windows or on Linux?   IMHO all scripts
> should be set to eol-style native because then local editing on the
> local system will do the right thing..  Although if you're doing your
> work on a Windows system and then creating a patch, yes, it's sort of
> going to expect the patch to be applied on Windows.
>
> However I believe that changing the line-ending to LF would
> be.. inappropriate.  It would make editing on Windows harder, and your
> patches will most likely still have CRLF in them!
>
> It's pretty easy to strip out CRLF from your patches using 'tr'.
>
> -derek
>
> --
>       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
>       Member, MIT Student Information Processing Board  (SIPB)
>       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
>       warlord at MIT.EDU                        PGP key available
>



-- 
Regards

Tao Wang