r18945 - gnucash/trunk/src/gnome-utils - Fix bug #613375

Geert Janssens janssens-geert at telenet.be
Mon Mar 22 13:54:58 EDT 2010


On Sunday 21 March 2010, John Ralls wrote:
> Author: jralls
> Date: 2010-03-21 16:38:12 -0400 (Sun, 21 Mar 2010)
> New Revision: 18945
> Trac: http://svn.gnucash.org/trac/changeset/18945
> 
> Modified:
>    gnucash/trunk/src/gnome-utils/gnc-main-window.c
> Log:
> Fix bug #613375
> 
> Odd that this affected only OSX, as the fix is clearly consistent with the
>  GtkLabel "ellipsize" property documentation. (I.e., the packing "expand"
>  property must be TRUE on notebook labels.)
> 
> 
<snip>

John,

Out of curiosity, what's the reason for the differentiation between GTK_QUARTZ 
and other GTK implementations below ?
> +#ifdef GTK_QUARTZ
> +    gnc_main_window_connect(window, page, tab_hbox, label);
> +#else
>      gnc_main_window_connect(window, page, event_box, label);
> -
> +#endif
>      LEAVE("");
>  }
> 

And I wonder why you removed the "TRUE" part in the code below:
> @@ -3212,7 +3213,7 @@
>      priv->notebook = gtk_notebook_new ();
>      g_object_set(G_OBJECT(priv->notebook),
>                   "scrollable", TRUE,
> -                 "enable-popup", TRUE,
> +                 "enable-popup",
>                   (char *)NULL);
>      gtk_widget_show (priv->notebook);
>      g_signal_connect (G_OBJECT (priv->notebook), "switch-page",
Does that also have something to do with Quartz ?

Geert


More information about the gnucash-devel mailing list