r18945 - gnucash/trunk/src/gnome-utils - Fix bug #613375

John Ralls jralls at ceridwen.us
Mon Mar 22 16:39:26 EDT 2010


On Mar 22, 2010, at 10:54 AM, Geert Janssens wrote:

> Out of curiosity, what's the reason for the differentiation between GTK_QUARTZ 
> and other GTK implementations below ?
>> +#ifdef GTK_QUARTZ
>> +    gnc_main_window_connect(window, page, tab_hbox, label);
>> +#else
>>     gnc_main_window_connect(window, page, event_box, label);
>> -
>> +#endif
>>     LEAVE("");
>> }
>> 
> 
> And I wonder why you removed the "TRUE" part in the code below:
>> @@ -3212,7 +3213,7 @@
>>     priv->notebook = gtk_notebook_new ();
>>     g_object_set(G_OBJECT(priv->notebook),
>>                  "scrollable", TRUE,
>> -                 "enable-popup", TRUE,
>> +                 "enable-popup",
>>                  (char *)NULL);
>>     gtk_widget_show (priv->notebook);
>>     g_signal_connect (G_OBJECT (priv->notebook), "switch-page",
> Does that also have something to do with Quartz ?

The first is cruft (GTK_QUARTZ isn't the macro, it's GDK_QUARTZ, so that bit will never build) and the second is a mistake. I'll have a cleanup checked in as soon as the check build completes.

Thanks for catching them.

Regards,
John Ralls



More information about the gnucash-devel mailing list