r18955 - gnucash/trunk/src - MSVC compatibility: MSVC must not use g_fopen because it uses a different C runtime than the rest of (MSVC) file-handling functions.

Phil Longstaff plongstaff at rogers.com
Mon Mar 22 17:59:09 EDT 2010


On Mon, 2010-03-22 at 17:15 -0400, Christian Stimming wrote:
> Author: cstim
> Date: 2010-03-22 17:15:15 -0400 (Mon, 22 Mar 2010)
> New Revision: 18955
> Trac: http://svn.gnucash.org/trac/changeset/18955
> 
> Modified:
>    gnucash/trunk/src/backend/xml/gnc-backend-xml.c
>    gnucash/trunk/src/backend/xml/io-gncxml-v2.c
>    gnucash/trunk/src/backend/xml/sixtp.c
>    gnucash/trunk/src/core-utils/gnc-gkeyfile-utils.c
>    gnucash/trunk/src/engine/TransLog.c
> Log:
> MSVC compatibility: MSVC must not use g_fopen because it uses a different C runtime than the rest of (MSVC) file-handling functions.

If we're starting to get into conditional compilation based on
compiler/platform, I think I'll introduce a scheme based on what webkit
has.  Basically, there's a platform.h file which contains macros so that
you can use:

#if COMPILER(MSVC)
#if PLATFORM(WIN32)
#if HAVE(ABC)
#if USE(WEBKIT)
#if ENABLE(FEATURE)

I think it looks a lot cleaner than what we have now (e.g. MSC_VER)

Phil



More information about the gnucash-devel mailing list