[PATCH] Repair automatch_store_transactions

Christian Stimming stimming at tuhh.de
Sat Oct 23 16:24:52 EDT 2010

Thanks for the reminder. I'm sorry nobody came around to give more feedback. 
I'll look into this the next days.

However, AFAIK your patch introduces new strings. Unfortunately we are 
currently in string freeze for another few weeks until 2.4.0 is out. After 
that, you patch can go into SVN right away.

In order not to have your patches forgotten again, I would suggest filing them 
as a bugzilla item with the patches attached as patches. That way, they would 
keep showing up in bugzilla's "Show all patches for gnucash" queries, which 
several of the developers will check regularly. Just for information.



Am Samstag, 23. Oktober 2010 schrieb Simon Ruggier:
> Hi all, I'd appreciate it if someone would take the time to review and
> respond to my previous message. I've reattached the patches for your
> convenience.
> On Sat, Aug 21, 2010 at 11:21 PM, Simon Ruggier <simon80 at gmail.com> wrote:
> > Hey all, I finally finished implementing everything I mentioned back
> > in early 2009, except the KvpFrame stuff. It's been hard to find time
> > to work on this, and the KvpFrame issue isn't really any more of a
> > problem as a result of my changes, so I think I will draw the line
> > here. I ended up making automatched transactions yellow, like
> > unbalanced transactions, since the user is expected to pick a
> > destination in both cases. The idea is that the user will go through
> > and review all of the automatched transactions, switching them to
> > manual one by one using the A column checkbox, untill all of the items
> > in the dialog are green.
> > 
> > I make a special case for unbalanced rows, which are checked, not
> > inconsistent, and cannot be toggled to manual using the "A" column
> > checkbox. They can still be switched to a state where the destination
> > account is manually set to the Imbalance account,  through the picker
> > dialog. One quirk of doing it this way is that these items sort with
> > manually set items instead of with automatched items, despite being
> > yellow. I would just as soon have unbalanced rows work exactly the
> > same way as other automatched accounts, but I figured that the dialog
> > discourages setting Imbalance as the destination account, so the
> > behaviour I chose is meant to continue that.
> > 
> > Patches are attached.
> > 
> > On Wed, Feb 11, 2009 at 9:00 PM, Simon Ruggier <simon80 at gmail.com> wrote:
> >> On Wed, Feb 11, 2009 at 1:20 AM, David Reiser <dbreiser at earthlink.net> 
> >>> Sorry for my screw-up. And thank you very much for taking the time to
> >>> track down these bugs.
> >> 
> >> No problem, and I appreciate that you took the time to test my patch.
> >> 
> >> As mentioned before, I do intend to make the following changes when I
> >> get the chance, so comments are welcome:
> >> - make automatched transactions a different colour (suggestions
> >> welcome :) probably blue, or a different shade of green), and update
> >> the help dialog to reflect this, of course
> >> - change the add checkbox behaviour to allow the user to quickly
> >> change an automatched transaction to manual (this should be quick),
> >> and also mention this in the help dialogue
> >> - try to decrement token counts in KvpFrames so that the token counts
> >> match the account data

More information about the gnucash-devel mailing list