[PATCH] Repair automatch_store_transactions

[Simon Ruggier]

Hi all, I'd appreciate it if someone would take the time to review and
respond to my previous message. I've reattached the patches for your
convenience.

On Sat, Aug 21, 2010 at 11:21 PM, Simon Ruggier <simon80 at gmail.com> wrote:
> Hey all, I finally finished implementing everything I mentioned back
> in early 2009, except the KvpFrame stuff. It's been hard to find time
> to work on this, and the KvpFrame issue isn't really any more of a
> problem as a result of my changes, so I think I will draw the line
> here. I ended up making automatched transactions yellow, like
> unbalanced transactions, since the user is expected to pick a
> destination in both cases. The idea is that the user will go through
> and review all of the automatched transactions, switching them to
> manual one by one using the A column checkbox, untill all of the items
> in the dialog are green.
>
> I make a special case for unbalanced rows, which are checked, not
> inconsistent, and cannot be toggled to manual using the "A" column
> checkbox. They can still be switched to a state where the destination
> account is manually set to the Imbalance account,  through the picker
> dialog. One quirk of doing it this way is that these items sort with
> manually set items instead of with automatched items, despite being
> yellow. I would just as soon have unbalanced rows work exactly the
> same way as other automatched accounts, but I figured that the dialog
> discourages setting Imbalance as the destination account, so the
> behaviour I chose is meant to continue that.
>
> Patches are attached.
>
> On Wed, Feb 11, 2009 at 9:00 PM, Simon Ruggier <simon80 at gmail.com> wrote:
>> On Wed, Feb 11, 2009 at 1:20 AM, David Reiser <dbreiser at earthlink.net> wrote:
>>> Sorry for my screw-up. And thank you very much for taking the time to track
>>> down these bugs.
>>
>> No problem, and I appreciate that you took the time to test my patch.
>>
>> As mentioned before, I do intend to make the following changes when I
>> get the chance, so comments are welcome:
>> - make automatched transactions a different colour (suggestions
>> welcome :) probably blue, or a different shade of green), and update
>> the help dialog to reflect this, of course
>> - change the add checkbox behaviour to allow the user to quickly
>> change an automatched transaction to manual (this should be quick),
>> and also mention this in the help dialogue
>> - try to decrement token counts in KvpFrames so that the token counts
>> match the account data
>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-import-main-matcher.c-remove-stray-comment.patch
Type: text/x-diff
Size: 847 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20101023/36bf7607/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Don-t-bother-caching-parsed-colors-in-struct-_main_m.patch
Type: text/x-diff
Size: 2783 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20101023/36bf7607/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Import-dialog-Change-imbalanced-transaction-colour-f.patch
Type: text/x-diff
Size: 801 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20101023/36bf7607/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Import-dialog-Extend-the-A-column-checkbox-behaviour.patch
Type: text/x-diff
Size: 7299 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20101023/36bf7607/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Import-dialog-Make-automatic-and-unbalanced-selectio.patch
Type: text/x-diff
Size: 8830 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20101023/36bf7607/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Import-dialog-Show-inconsistent-A-checkbox-for-autom.patch
Type: text/x-diff
Size: 8708 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20101023/36bf7607/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Repair-automatch_store_transactions.patch
Type: text/x-diff
Size: 3728 bytes
Desc: not available
URL: <http://lists.gnucash.org/pipermail/gnucash-devel/attachments/20101023/36bf7607/attachment-0006.bin>