Patch, patch submission questions and general configure/make questions

[Christian Stimming]

Am Montag, 6. Juni 2011 schrieb Tim M:
> I just wanted to check on the method you prefer for submitting
> patches.  I wrote a patch or two some time ago for gnucash and am
> hoping to get back into doing some coding on the application if/when I
> have free time, but wanted to see if you prefer patches to be
> submitted to the mailing list or for a defect to be created in
> Bugzilla first and then if I create a patch for the defect to submit
> it there, or some other process?

We prefer patches in bugzilla,
http://wiki.gnucash.org/wiki/Development#Code 
Also, if you're using git locally, please submit patches through "git format-
patch".

> -----------------------
> make[3]: Leaving directory
> `/home/tim/Development/gnucash/development/gnucash/lib/stf'
> stf-parse.c:562: error: comma at end of enumerator list
> make[3]: *** [stf-parse.lo] Error 1
> -----------------------
> 
> For the record, I am using the following configure options and after
> fixing the above error, many more cropped up.  It seems --enable-iso-c
> is probably causing many errors to appear

As Mike already mentioned: Please don't use --enable-iso-c.

> The above error is quite a simple fix:
> 
> --- gnucash/lib/stf/stf-parse.c	(revision 20735)
> +++ gnucash/lib/stf/stf-parse.c	(working copy)

The code under lib/... is copied from somewhere else and is not developed 
within gnucash. This means we don't want to touch it, except if there are 
obvious bugs that might need to be fixed.

> I am wondering if it is desired to fix the build errors which are
> appearing due to my configure options or if I should simply change
> those options?  I have limited C++ experience so currently small
> patches such as this are easy for me and probably a good use of my
> time getting familiar with the code, but let me know if this is not
> desired.  I do have some work I would like to accomplish on
> new/improved budgeting features _eventually_ in the future if my
> ability increases to the point that I can manage it, but I will only
> have time and ability for smaller patches for the time being.

Both are fine. Feel free to work on whatever you prefer for yourself right 
now. Feel free to submit patches for "simple" things such as comment clean-up 
or even code clean-up for ISO C89, as long as it doesn't make the code less 
readable. We are looking forward to seeing your patches!

Regards,

Christian