[PATCH] Reset Warnings dialog: show translated warnings

Geert Janssens janssens-geert at telenet.be
Sat Dec 21 07:00:16 EST 2013

On Saturday 14 December 2013 20:52:53 Aurimas Fišeras wrote:
> Hi,
> I'm not sure it is 100% correct, as for some reason not all warning
> descriptions are shown translated with the patch applied (none are
> without it).

Sorry for the slow response. Non-gnucash related work is taking most of my time recently.

Your patch is correct. I have applied it in r23588 with only a minor tweak: I replaced "gettext" 
with "_" to be consistent with the rest of the gnucash code.

The reason some strings are not translated was to be found elsewhere. Some strings in the 
gschema files use double blanks ("  ") between sentences. gettext collapses these double 
blanks in one single blank
(" ") when it extracts the strings. The exact same strings are also used to generate the source 
file gnc-warnings.c, but in this process the double blanks are *not* collapsed. So in the end you 
get two different message id's generated from the same source file: the one in the po files with 
single blanks and the one in gnc-warnings.c with double blanks. So when the time comes to 
look up a translation, these id's don't match and hence no translation is found.

I have committed r23589 to remove all double blanks from the gschema files. That should fix 
the apparently missing translations.

Thanks for your contributions (in small patches and translations !)


More information about the gnucash-devel mailing list