[PATCH] Add back translation support in combo boxes

Geert Janssens janssens-geert at telenet.be
Fri Jul 5 13:15:23 EDT 2013

On 03-07-13 16:11, John Ralls wrote:
> On Jul 3, 2013, at 6:57 AM, John Ralls <jralls at ceridwen.us> wrote:
>> The _() macro just calls gettext(), which takes the passed-in string, compares it against the
>> appropriate message catalog, and returns a translation if it finds one, and the provided string
>> if it doesn't.
>> So passing a variable to _() is fine. The potential problem is the other use of _() -- or gettext() --
>> which is to flag an enclosed string constant for xgettext to extract and include in the pot file.
>> I don't see where that part is done, but if it is somewhere, then there's no gettext problem.
> Sorry, that didn't make sense. What I meant to say is that one should pass variables to _() only
> if the constant values have been flagged to xgettext so that they're in the message catalog. I
> don't see where that happens in the code, but the gnc_option_get_permissible_values functions
> refer to a struct of SCM variables, so perhaps it's done in scheme somewhere.
> Regards,
> John Ralls
Ok, that means I was worrying for no good reason. I have applied your 
patch. Thank you very much !


More information about the gnucash-devel mailing list