no git patchset from .news files? (was Re: gnucash-htdocs branch master updated. svn_last-12-g3580119)

[John Ralls]

On Jul 10, 2013, at 2:35 PM, Geert Janssens <janssens-geert at telenet.be> wrote:

> Op 10/07/13 05:44, John Ralls schreef:
>> On Jul 9, 2013, at 2:47 PM, Derek Atkins <warlord at MIT.EDU> wrote:
>> 
>>> Geert,
>>> 
>>> There appears to be something wrong, still, with the git email script
>>> with the htdocs repo.  For example, this email just came through:
>>> 
>>> Cristian Marchi <cmarchi at code.gnucash.org> writes:
>>> 
>>>> The master branch has been updated
>>>>       via  https://github.com/Gnucash/gnucash-htdocs/commit/35801191 (commit)
>>>>      from  https://github.com/Gnucash/gnucash-htdocs/commit/f8f95043 (commit)
>>>> 
>>>> 
>>>> - Log -----------------------------------------------------------------
>>>> -----------------------------------------------------------------------
>>>> 
>>>> Summary of changes:
>>>> news/130528-announce-2.5.2.news |    2 +-
>>>> news/130707-announce-2.5.3.news |    2 +-
>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>> 
>>>> 
>>>> hooks/post-receive
>>> As you can see, there is no patch in the email.  However, if I run "git
>>> show -C 35801191" manually from code within the htdocs repo I *do* get a
>>> patch output.  So something is going wrong, somewhere.
>>> 
>>> What do we need to do to debug and fix this?
> I have seen this as well. I'm currently abroad and won't be able to look into this until I'm back.
>> There are some other problems as well, starting with the subject being "gnucash-htdocs branch master updated. svn_last-12-g3580119" instead of the first line of the commit message.
> The git mails are not using the first line of the commit message because the mail is not sent per commit, but per push. For gnucash-htdocs with its low update rate, usually one push equals one commit. But for the gnucash main repository I expect to see frequent pushes of multiple commits. When there are multiple commits to report in one mail, it doesn't make sense to use the first line of one single commit.
> 
> Unless you want to completely rewrite the mail script ? The script I've used seems to be commonly used in other git repositories as well. It takes some getting used to, particularly due to our familiarity with the svn commit mails.

I don't think a complete rewrite is necessary, just a tweak to the code which writes the subject header: If there's only one change it can write the first line to the subject, otherwise it can say something like "$repo $branch received multiple commits".

A couple of other noise-reducing changes to consider:

* Lose the "parent" URL. There's a link for it on the commit page.
* Suppress printing $LOGBEGIN and LOGEND (the lines with all the hyphens) unless something's going to get printed between them -- or better yet, just lose them. It's pretty obvious what's log, what's patch, and what's summary. They don't need delimiting.
* Lose the footer. "hooks/post-recieve" isn't information.

Regards,
John Ralls