r22987 - gnucash/trunk - Fix a typo in both source and po files.

Cristian Marchi cri79 at libero.it
Sun May 19 03:49:13 EDT 2013


Ok, sorry; I should have asked before committing the changes. I've run a 
sed command and committed. Lesson learned for next time!

Thanks
Cristian

Il 18/05/2013 22.07, Christian Stimming ha scritto:
> Hi Cristian,
>
> thanks for spotting this typo and fixing it.
>
> However, please be a bit more cautious about the types of files that you
> change in one commit: In cases like this where you fix or change the wording
> in a user-visible message, I'd like to ask you to make one commit that *only*
> changes the respective source file (.h, .c., .glade or similar). Please do not
> change all the po files in the same commit. Changing the po files (and even
> all of them) should be done very seldomly. Usually the translators will merge
> with a pot template anyway, and that pot is then generated from the very
> latest source anyway. Having all po files changed makes this single commit
> rather hard to read, i.e. when I want to know "What is the real change in this
> commit", I have to search through all 30 files that have been changed but the
> real important change was only in assistant-csv-trans-import.glade. Hence, in
> cases like this, please make one commit that only changes the source file. The
> additional changes in the po files can either be ignored (and only your it.po
> gets updated by you), or sent in a separate second commit.
>
> Even the changes in the code comments can go into yet another commit with a
> commit message such as "Fix typo in source comments", because that sort of
> commit message makes it clear that neither actual source code statements nor
> any user-visible messages have been changed.
>
> I hope you get the point: Changes can be of different level of importance, and
> those different levels should better not be mixed up into the same commit.
>
> Thanks of course for fixing the typo! I hope there will be many to come! :-)
>
> Regards,
>
> Christian
>
>
> Am Samstag, 18. Mai 2013, 09:22:35 schrieb Cristian Marchi:
>> Author: cmarchi
>> Date: 2013-05-18 09:22:24 -0400 (Sat, 18 May 2013)
>> New Revision: 22987
>> Trac: http://svn.gnucash.org/trac/changeset/22987
>>
>> Modified:
>>     gnucash/trunk/po/bg.po
>>     gnucash/trunk/po/ca.po
>>     gnucash/trunk/po/cs.po
>>     gnucash/trunk/po/da.po
>>     gnucash/trunk/po/de.po
>>     gnucash/trunk/po/el.po
>>     gnucash/trunk/po/en_GB.po
>>     gnucash/trunk/po/es.po
>>     gnucash/trunk/po/es_NI.po
>>     gnucash/trunk/po/eu.po
>>     gnucash/trunk/po/fa.po
>>     gnucash/trunk/po/fi.po
>>     gnucash/trunk/po/fr.po
>>     gnucash/trunk/po/he.po
>>     gnucash/trunk/po/hu.po
>>     gnucash/trunk/po/it.po
>>     gnucash/trunk/po/ja.po
>>     gnucash/trunk/po/ko.po
>>     gnucash/trunk/po/lt.po
>>     gnucash/trunk/po/lv.po
>>     gnucash/trunk/po/nb.po
>>     gnucash/trunk/po/ne.po
>>     gnucash/trunk/po/nl.po
>>     gnucash/trunk/po/pl.po
>>     gnucash/trunk/po/pt.po
>>     gnucash/trunk/po/pt_BR.po
>>     gnucash/trunk/po/ro.po
>>     gnucash/trunk/po/ru.po
>>     gnucash/trunk/po/rw.po
>>     gnucash/trunk/po/sk.po
>>     gnucash/trunk/po/sv.po
>>     gnucash/trunk/po/ta.po
>>     gnucash/trunk/po/tr.po
>>     gnucash/trunk/po/uk.po
>>     gnucash/trunk/po/vi.po
>>     gnucash/trunk/po/zh_CN.po
>>     gnucash/trunk/po/zh_TW.po
>>     gnucash/trunk/src/import-export/csv-export/assistant-csv-export.h
>>     gnucash/trunk/src/import-export/csv-export/csv-transactions-export.h
>>     gnucash/trunk/src/import-export/csv-export/csv-tree-export.h
>>     gnucash/trunk/src/import-export/csv-import/assistant-csv-account-import.h
>> gnucash/trunk/src/import-export/csv-import/assistant-csv-trans-import.glade
>> gnucash/trunk/src/import-export/csv-import/assistant-csv-trans-import.h
>> Log:
>> Fix a typo in both source and po files.
>>
>> _______________________________________________
>> gnucash-patches mailing list
>> gnucash-patches at gnucash.org
>> https://lists.gnucash.org/mailman/listinfo/gnucash-patches



More information about the gnucash-devel mailing list