[Patch] Bug 712640: gnc-engine.c parallel optimization

[John Ralls]

On Nov 18, 2013, at 3:28 PM, Alex Kempster <alkempster.cu at gmail.com> wrote:

> Hello,
> 
> I made a minor performance optimisation which is attached to:
> https://bugzilla.gnome.org/show_bug.cgi?id=712640 . Would someone be kind
> enough to provide feedback /  merge it with the repository?
> 
> The optimisations use OpenMP so to utilise it you may need to add a
> ./configure option:
> 
> ./configure CFLAGS=-fopenmp
> 
> not including the above will compile without the optimisation and shouldn't
> affect normal operation / compilation in any way.
> 
> Thanks for your time!

Shot down. In Flames. And you were totally out of line to change the wiki to make it appear that your change was accepted.

Look, you can’t just jam MP into a single-threaded program. At best it accomplishes nothing beyond adding a dependency. At worst, and far more likely, it causes corrupted data and random crashes. It’s in no way a “minor performance optimization”.

I suggested to you a week ago that you start working on bugs. I mean that. But before you try again, at least learn how to make a patch.

BTW, “config.h” is always the first #include. It pulls in all of the #defines from configure. Your replacement gnc-engine.c included <omp.h> before it.

Regards,
John Ralls