[Patch] Bug 712640: gnc-engine.c parallel optimization

Alex Kempster alkempster.cu at gmail.com
Mon Nov 18 20:07:16 EST 2013

At least I tried. You seem to be very negative about that. I thought that I
was clear that I am new to open source development, I expected to make
mistakes. I have spent hours on attempting to get familiar with a project
and help the best way I can. I tried several bugs to no avail. I went
through many source files which contain little documentation, some bugs
date back to 2007. I am not sure what you expected but thats no reason to
be so negative, especially on a project that is short on developers. I will
undo the wiki changes first thing tommorow and leave it at that. I want to
help, im not going to get everythimg right first time. That being said, why
should I try and make an effort when I get a response that is so negative?

The documentation for patches is unclear, and, unless I attempted to make a
patch how could I know if its the correct way for certain? Do you have a
beginners wiki page that I missed? Perhaps one should be created so that
new developers have a decent chance at submitting patches correctly and
knowing that config.h should be the first include. I put omp.h first so
that any duplicate definitions would get overwritten by the original set of

I would argue that open mp inclusion at this stage wouldnt cause any
problems as without the compiler flag all the changes would be ignored. But
it is a moot point.

Your thoughts on the above begginer developer wiki page?

As per a week ago I suggested making magic number replacement definitions
as I thought it would be a small work... you said it was pointless. I shall
ask again, is it worth me doing, that way I can get familiar with creating
patches and I know it is something you would appreciate even if it would be
depricated soon. Please bear in mind I know C, not guile or many of the
libraries used . Perhaps it would be best for me to play to my strengths
rather than try to triage bugs relating to libraries that I have never

Perhaps you could set up a wiki change pre approval system so mistakes like
that dont occur in the future. I made that change as the wiki said to make
documentation changes before changing code.
On 19 Nov 2013 00:34, "John Ralls" <jralls at ceridwen.us> wrote:

> On Nov 18, 2013, at 3:28 PM, Alex Kempster <alkempster.cu at gmail.com>
> wrote:
> > Hello,
> >
> > I made a minor performance optimisation which is attached to:
> > https://bugzilla.gnome.org/show_bug.cgi?id=712640 . Would someone be
> kind
> > enough to provide feedback /  merge it with the repository?
> >
> > The optimisations use OpenMP so to utilise it you may need to add a
> > ./configure option:
> >
> > ./configure CFLAGS=-fopenmp
> >
> > not including the above will compile without the optimisation and
> shouldn't
> > affect normal operation / compilation in any way.
> >
> > Thanks for your time!
> Shot down. In Flames. And you were totally out of line to change the wiki
> to make it appear that your change was accepted.
> Look, you can’t just jam MP into a single-threaded program. At best it
> accomplishes nothing beyond adding a dependency. At worst, and far more
> likely, it causes corrupted data and random crashes. It’s in no way a
> “minor performance optimization”.
> I suggested to you a week ago that you start working on bugs. I mean that.
> But before you try again, at least learn how to make a patch.
> BTW, “config.h” is always the first #include. It pulls in all of the
> #defines from configure. Your replacement gnc-engine.c included <omp.h>
> before it.
> Regards,
> John Ralls

More information about the gnucash-devel mailing list