r23397 - gnucash/trunk/src - Bug 336843: Attach images/files/urls to transactions.

John Ralls jralls at ceridwen.us
Sun Nov 24 11:49:19 EST 2013

On Nov 24, 2013, at 6:26 AM, Patrick <patrick at setsuid.net> wrote:

> Indeed I assumed that gvfs wasn't available on non-linux/gnome
> platforms, hence my (failed) attempt at implementing the win32/mac
> code sections.
> Someone commented earlier that the import/associate functionality used
> by the open-source project "Shotwell" would be a good model. I'd be
> inclined to agree. Giving the user an option to choose between
> importing (copying) or just linking to an existing file would be
> preferable, in my opinion.
> More immediately, I just test-drove 2.5.8 and found that the
> "Associate Location" option brings up a dialog to select a file as
> well as enter a URI. (The former appearing to be unused). I'd looked
> for an integrated chooser so that only one option "Associate" would be
> necessary, however I was unable to find one. Comparing with "gimp" I
> regarded their use of differing options as a validation that two
> selection paths were necessary (file and URI).
> In any case, the gtk dialog call in
> default_associate_handler_location() was changed to
> gtk_file_chooser_dialog_new()
> from my best guess of gtk_dialog_new_with_buttons(). This change
> added a file chooser to the URI dialog, which appears superfluous.

Yes, because you were trying to pass  GTK_FILE_CHOOSER_ACTION_OPEN to gtk_dialog_new_with_buttons, which raised a mismatched enum type from Clang. I guessed that you got the function wrong rather than the enum; wrong guess, I guess. I'll fix it the other way.

John Ralls

More information about the gnucash-devel mailing list