r23397 - gnucash/trunk/src - Bug 336843: Attach images/files/urls to transactions.

Patrick patrick at setsuid.net
Sun Nov 24 12:31:43 EST 2013

Ah! Makes sense.. A leftover from copying that function from
default_associate_handler_file() (which does use the FILE_CHOOSER).


On Sun, Nov 24, 2013 at 11:49 AM, John Ralls <jralls at ceridwen.us> wrote:
> On Nov 24, 2013, at 6:26 AM, Patrick <patrick at setsuid.net> wrote:
>> In any case, the gtk dialog call in
>> default_associate_handler_location() was changed to
>> gtk_file_chooser_dialog_new()
>> from my best guess of gtk_dialog_new_with_buttons(). This change
>> added a file chooser to the URI dialog, which appears superfluous.
> Yes, because you were trying to pass  GTK_FILE_CHOOSER_ACTION_OPEN to gtk_dialog_new_with_buttons, which raised a mismatched enum type from Clang. I guessed that you got the function wrong rather than the enum; wrong guess, I guess. I'll fix it the other way.
> Regards,
> John Ralls

More information about the gnucash-devel mailing list