Loading XML V1 files

[Geert Janssens]

On Friday 22 November 2013 16:08:05 Mike Alexander wrote:
> I just checked in a change that might break the loading of XML V1
> files (although I don't think it will).  I changed things so that the
> progress bar is updated while loading the price data base in an XML
> V2 file.  In doing this I ran across some comments that indicated
> that this wasn't done in the past because doing so would break
> loading of V1 files.  However, those comments were written in 2001
> (for r3772) and I don't think they apply now.
> 
> Does anyone have an XML V1 file with prices in it that I could use to
> test this?  Does anyone care whether it works or not?  I wouldn't be
> surprised if previous changes have broken the loading of V1 files. 
> Has anyone tried this recently?  If not should support for them be
> removed?
> 
>               Mike
> 
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Mike,

since you committed these changes I have a failing test in the xml backend. This is after John's 
patches to fix these tests.

The failing test for me is test-xml-pricedb. This test still seems to call the V1 xml code. Could 
that be related to your changes ?

Here is the backtrace:
(gdb) bt
#0  0x0000000000643930 in ?? ()
#1  0x0000000000417139 in run_callback (data=0x7fffffffda20, type=0x4224b6 "prices")
    at /kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/backend/xml/io-
gncxml-v2.c:113
#2  0x0000000000416508 in pricedb_after_child_handler (data_for_children=0x0, 
data_from_children=0x635450 = {...}, sibling_data=0x0, parent_data=0x0, 
    global_data=0x7fffffffd9e0, result=0x6b8830, tag=0x6b87f0 "gnc:pricedb", 
child_tag=0x6b8710 "price", child_result=0x6ba5c0)
    at /kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/backend/xml/gnc-
pricedb-xml-v2.c:303
#3  0x000000000040f161 in sixtp_sax_end_handler (user_data=0x6b0480, name=0x6b830b 
"price")
    at /kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-
git/src/backend/xml/sixtp.c:590
#4  0x00000032ba44756d in xmlParseEndTag1 () from /lib64/libxml2.so.2
#5  0x00000032ba44dafb in xmlParseElement () from /lib64/libxml2.so.2
#6  0x00000032ba44d008 in xmlParseContent () from /lib64/libxml2.so.2
#7  0x00000032ba44d8a3 in xmlParseElement () from /lib64/libxml2.so.2
#8  0x00000032ba44deca in xmlParseDocument () from /lib64/libxml2.so.2
#9  0x000000000040f413 in sixtp_parse_file_common (sixtp=0x696d70, 
xml_context=0x6ac860, data_for_top_level=0x0, global_data=0x7fffffffd9e0, 
    parse_result=0x7fffffffd9f8) at /kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-
git/src/backend/xml/sixtp.c:711
#10 0x000000000040f500 in sixtp_parse_file (sixtp=0x696d70, filename=0x696df0 
"test_file_L5446W", data_for_top_level=0x0, global_data=0x7fffffffd9e0, 
    parse_result=0x7fffffffd9f8) at /kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-
git/src/backend/xml/sixtp.c:758
#11 0x00000000004103e3 in gnc_xml_parse_file (top_parser=0x696d70, filename=0x696df0 
"test_file_L5446W", callback=0x41b478 <test_add_pricedb>, 
    parsedata=0x7fffffffda20, bookdata=0x6428d0) at 
/kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/backend/xml/io-gncxml-
gen.c:41
#12 0x000000000041b620 in test_db (i=0, db=0x643930) at 
/kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/backend/xml/test/test-xml-
pricedb.c:110
#13 0x000000000041b715 in test_generation () at 
/kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/backend/xml/test/test-xml-
pricedb.c:142
#14 0x000000000041b76a in main (argc=1, argv=0x7fffffffdb78)
    at /kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/backend/xml/test/test-
xml-pricedb.c:158


Geert