-Wno-deprecated-register with Clang

[Geert Janssens]

On Wednesday 02 July 2014 11:55:32 John Ralls wrote:
> On Jul 2, 2014, at 10:50 AM, Geert Janssens <janssens-geert at telenet.be> wrote:
> > On Wednesday 02 July 2014 09:58:28 John Ralls wrote:
> > 
> 
> > If I revert Mike's commit I get a little further, but still it breaks in qof/test:
> What commit is that? I think you mean my commit, which disables
> -Wno-deprecated-register on clang. I just pushed a replacement which
> tests for accepting no-deprecated-register, a better strategy than
> testing for a particular compiler anyway.

Ehrm right - that was your commit. Sorry for the confusion.

> > clang -DHAVE_CONFIG_H -I.
> > -I/kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/li
> > bqof/qof/test -I../../../..  -I.
> > -I/kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/li
> > bqof/qof/test -I../../../..
> > -I/kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/li
> > bqof/qof
> > -I/kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/te
> > st-core -DTESTPROG=test_qof
> > -I/kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/lib/li
> > bc -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  
> > -Werror -Wdeclaration-after-statement -Wno-pointer-sign  -Wall
> > -Wunused -Wmissing-prototypes -Wmissing-declarations  -Wno-unused
> > -g  -g  -MT test_qof-test-qofbook.o -MD -MP -MF
> > .deps/test_qof-test-qofbook.Tpo -c -o test_qof-test-qofbook.o `test
> > -f 'test-qofbook.c' || echo
> > '/kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/lib
> > qof/qof/test/'`test-qofbook.c
> > /kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/libq
> > of/qof/test/test-qofbook.c:264:52: error: expression which evaluates
> > to zero treated as a null pointer constant of type 'const char *'> 
> >       [-Werror,-Wnon-literal-null-conversion]
> >     
> >     counter = qof_book_get_counter( fixture->book, '\0' );
> >     
> >                                                    ^~~~
> > 
> > /kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/libqo
> > f/qof/test/test-qofbook.c:301:53: error: expression which evaluates
> > to zero treated as a null pointer constant of type 'const char *'> 
> >       [-Werror,-Wnon-literal-null-conversion]
> >     
> >     r = qof_book_get_counter_format( fixture->book, '\0' );
> >     
> >                                                     ^~~~
> > 
> > /kobaltnet/janssege/Development/EclipseGnuCash/GnuCash-git/src/libqo
> > f/qof/test/test-qofbook.c:343:63: error: expression which evaluates
> > to zero treated as a null pointer constant of type 'const char *'> 
> >       [-Werror,-Wnon-literal-null-conversion]
> >     
> >     r = qof_book_increment_and_format_counter( fixture->book, '\0'
> >     );
> >     
> >                                                               ^~~~
> > 
> > 3 errors generated.
> > make[5]: *** [test_qof-test-qofbook.o] Error 1
> > make[5]: Leaving directory
> > `/kobaltnet/janssege/Development/Builds/gnucash-f20-master/src/libq
> > of/qof/test' make[4]: *** [all-recursive] Error 1
> > make[4]: Leaving directory
> > `/kobaltnet/janssege/Development/Builds/gnucash-f20-master/src/libq
> > of/qof' make[3]: *** [all-recursive] Error 1
> > make[3]: Leaving directory
> > `/kobaltnet/janssege/Development/Builds/gnucash-f20-master/src/libq
> > of' make[2]: *** [all-recursive] Error 1
> > make[2]: Leaving directory
> > `/kobaltnet/janssege/Development/Builds/gnucash-f20-master/src'
> > make[1]: *** [all-recursive] Error 1
> > make[1]: Leaving directory
> > `/kobaltnet/janssege/Development/Builds/gnucash-f20-master' make:
> > *** [all] Error 2
> 
> We can replace those three instances with NULL; I just checked and
> they're the only ones. I'll push that change later.
> 
Ok, thanks,

Geert