semantics of importer account_id

John Ralls jralls at ceridwen.us
Wed Nov 4 23:26:23 EST 2015


> On Nov 4, 2015, at 6:12 AM, G. Paul Ziemba <pz-gnucash-devel at ziemba.us> wrote:
> 
> I wrote:
> 
>> The gnucash aqbanking importer constructs an online_id/account_id
>> as, roughly, bankcode + accountnumber.
> 
>> The ofx file importer uses the account_id provided by libofx, which
>> uses various string components among the set {acctid, acctkey,
>> brokerid, bankid, branchid} depending on the account type. Libofx
>> also seems to provide functions to access these individual components.
> 
> I made an initial patch for gnucash-2.6.4 (also applies cleanly
> to 2.6.9) to use separate per-importer namespaces for the online_id.
> (At present, this amounts to an "aqbanking" namespace and an "ofx"
> namespace).
> 
> This patch also removes my earlier hack at online_id compatibility
> between namespaces, which is superseded by the new approach.
> 
> So far I have tested only lightly, to ensure that it creates a new
> per-importer online_id entry for an account, and that it falls back
> to using the single per-account online_id when attempting a match if
> a per-importer match is not found. I will continue using it to see if
> any other issues come up.
> 
> If anyone would like to review/comment on the code or try it out
> (NO WARRANTY!  Back up your accounts file before using!), the patch
> is available here:
> 
> http://enrico.users.sonic.net/patches/gnucash-2.6.4/patch-online-id-namespaces-01
>
If you decide at some point to submit your patch for inclusion in GnuCash, please see http://wiki.gnucash.org/wiki/Development#Submitting_Patches for acceptable ways to submit patches. Note that posting to the mailing list isn’t one of them, and basing patches on tarballs isn’t either.

Since you seem to be looking for comments, I suggest that a Github fork is a better place for that than a patch file on your personal website, as it permits comments to be made inline with your code.


Regards,
John Ralls






More information about the gnucash-devel mailing list