Patch : editing "Posted" time of transactions.
gletteryyumeansjletteryot at gmail.com
Fri Jan 29 05:44:53 EST 2016
Thank you very much for the help your comments provide to me !
I accept without additionnal question all of your comments that are not quoted
below, and will work on them.
2016-01-28 19:54 UTC+01:00, John Ralls <jralls at ceridwen.us>:
> Don't remove function description comments; do make them Doxygen markup.
I did that because some function description comments were removed between
gnucash-2.6.5 and end of 2015. Should I also revert those comments?
>> * if TZ is not defined, gnucash crashes immediately.
> The crashes alone make this patch incomplete and unacceptable as-written.
Can someone help me, by showing the right way to recover the time difference
due to the timezone settings at a given UTC date?
> But we still haven't decided whether to drop times altogether from
> date_posted, and this change, even if otherwise perfect, can't merge until
> we do.
Should I add changes to gnucash-2.4.12/src/gnome-utils/glade/preferences.glade
to let the user decide, at runtime, if he wants to see times or no ?
> BTW your
> incorrectly copies a GCC bug:
> https://sourceware.org/bugzilla/show_bug.cgi?id=15366 *and* overrides a
> #define that belongs to the libc/libc++ headers.
> (The bug was the result of the GCC folks following an effort by the ISO C
> committee to tell the ISO C++ committee what to do. The ISO C++ committee
> ignored them, but the GCC folks didn't. The ISO C committee fixed their
> overstep in C11. See http://en.cppreference.com/w/Talk:cpp/types/integer.
> Please remove that commit.
Is there a better way than reverting the source, then typing `git commit -a` ?
I am new to git, I mainly use cvs. I wonder if configure should or not bail out
in front of gcc 4.8.4 (Gentoo 4.8.4 p1.0, pie-0.6.1).
Best Regards, Daniel
NB: Thanks Geert for clarifying gnucash --help and helping me in this thread.
More information about the gnucash-devel