Patch : editing "Posted" time of transactions.

[Geert Janssens]

On Friday 29 January 2016 14:07:57 gLETTERyYuMEANSj LETTERyOt wrote:
> Dear Geert,
> 
> Thank you for your very helpful input !
> 
> >> 2016-01-28 19:54 UTC+01:00, John Ralls <jralls at ceridwen.us>:
> >> > Don't remove function description comments; do make them Doxygen
> >> > markup.
> > 
> > On Friday 29 January 2016 11:44:53 I wrote:
> >> I did that because some function description comments were removed
> >> between gnucash-2.6.5 and end of 2015. Should I also revert those
> >> comments?
> 
> 2016-01-29 12:47 UTC+01:00, Geert Janssens <geert.gnucash at kobaltwit.be>:
> > Can you provide some links to commits that remove comments ? There
> > may have been other
> > reasons this was done.
> 
> https://github.com/gijut/gnucash/commit/2b84dfae8d74371e300bfdcd0fab5f
> 2633dc732d (git-blame was useless to locate that URL, I had to try my
> luke on
> https://github.com/gijut/gnucash/commits/master/src/libqof/qof/gnc-da
> te.cpp)

You can use the commit hash found in git blame to compose github urls. Just replace the hash 
in the above url (the part following .../commit/) with the hash you found in git-blame. It doesn't 
matter if the hash from git blame is shorter.

> 
> I have well understood that I should not remove such comments,
> whatever the reason to above old commit.
> 
In the old commit the doxygen comments were removed because there were also doxygen 
comments for the same functions in the header file. Having them in both source and header 
files results in poor documentation because the comments get appended together. So rule of 
thumb: only add doxygen comments in the header files. You can add normal comments in the 
source files if more clarification is needed there.

> > Well definitely not to gnucash-2.4.12. That's a version of gnucash
> > that's no longer supported.
> > Are you working from an old tarball for your development ?
> 
> No. Sorry for the confusion. gnucash-2.4.12 is the first version on
> which I tried to show times, long ago. It got me nowhere, except to
> understand that the button "Use a 24 hour (instead of a 12 hour) time
> format", still present in latest gnucash preference forms and in line
> https://github.com/Gnucash/gnucash/blob/master/src/gnome-utils/gtkbuil
> der/dialog-preferences.glade#L1086 , was not able to show transaction
> times.
> 
> > on which direction to take on this. You can raise your voice there
> > and motivate why you believe
> > gnucash should keep time stamps [1]. Personally, I don't see much
> > use for it as I use gnucash,
> > but I'm not the only user :)
> 
> Time awareness is the most natural way for "Modeling multiple buys
> and/or sells" on the same day (quoted from a mail about stock
> exchange dated 2015/8/12 at 15h13 posted on the thread "Rounding in
> the price db." on this mailing list).

Have you cast your vote on the feature requests I referred to ? This discussion is not held on 
the mailinglist.
> 
> Should I add changes to
> src/gnome-utils/gtkbuilder/dialog-preferences.glade to let the user
> decide, at runtime, if he wants to see times or no ?

As I said, that depends on the actual final decision regarding time stamps. If we decide to keep 
them, I think a user settable option would be good. However I would rather see it settable per 
register. I may want to keep track of it for stock transactions but not for my cash register or 
expense registers.

Regards,

Geert