Reports: Utilization of urls

Geert Janssens geert.gnucash at kobaltwit.be
Wed Mar 9 16:10:07 EST 2016


On Wednesday 09 March 2016 22:07:37 Geert Janssens wrote:
> On Wednesday 09 March 2016 10:40:51 Derek Atkins wrote:
> > John Ralls <jralls at ceridwen.us> writes:
> > >> On Mar 8, 2016, at 11:32 AM, Carsten Rinke <carsten.rinke at gmx.de>
> > >> wrote:
> > >> 
> > >> The difference is the line chart option for budget reports: it
> > >> has
> > >> alrady been included on the master branch, but not on the maint
> > >> branch.
> > >> I did a git pull today again on both branches just to make sure I
> > >> did not miss anything.
> > > 
> > > Sorry, I didn't make the point clear: Should new reports be added
> > > in
> > > the middle of a stable release series or should they wait for the
> > > next major release? If the latter then there should be no commits
> > > to maint. The fact that line charts are already partly implemented
> > > in master is a strong argument that the others should, too.
> > 
> > I feel that it's okay for new reports to get added in the middle of
> > a
> > stable release.
> 
> The patch is making changes in existing reports to extend their
> behavior to either show a bar chart or a line chart. It's not adding
> new, independent reports. I agree with John this should only be
> committed to master in order to avoid unexpected issues in the stable
> series.
> 
> Regards,
> 
> Geert

Note that I haven't had time yet to test the proposed patch or for a thorough code review. 
That will follow later. The above conclusion is from a quick look at the patch.

Regards,

Geert


More information about the gnucash-devel mailing list