gnucash master: Multiple changes pushed

[Geert Janssens]

Op dinsdag 21 februari 2017 11:43:35 CET schreef Derek Atkins:
> Geert Janssens <geert.gnucash at kobaltwit.be> writes:
> > Hi John,
> > 
> > Op maandag 20 februari 2017 19:06:19 CET schreef John Ralls:
> >> @@ -246,7 +246,7 @@ inline GncRational operator+(GncRational a, GncInt128
> >> b) }
> >> 
> >>  inline GncRational operator+(GncInt128 a, GncRational b)
> >>  {
> >> 
> >> -    return b + GncRational(a, 1);
> >> +    return GncRational(a, 1) + a;
> >> 
> >>  }
> > 
> > Looks like one more copy/paste error or typo...
> > return GncRational(a, 1) + *b*;
> > 
> > It's weird this isn't caught in our unit tests (unless this is not
> > specifically tested for yet).
> 
> It's weird that this isn't caught by the *compiler* -- isn't an unused
> parameter a warning/error?
> 
> -derek

Good point. I went back to the ubuntu build of which I still had the build 
log. There was no warning for this.

Geert