gnucash master: Multiple changes pushed

[Derek Atkins]

Geert Janssens <geert.gnucash at kobaltwit.be> writes:

> Hi John,
>
> Op maandag 20 februari 2017 19:06:19 CET schreef John Ralls:
>
>> @@ -246,7 +246,7 @@ inline GncRational operator+(GncRational a, GncInt128 b)
>> }
>>  inline GncRational operator+(GncInt128 a, GncRational b)
>>  {
>> -    return b + GncRational(a, 1);
>> +    return GncRational(a, 1) + a;
>>  }
>
> Looks like one more copy/paste error or typo...
> return GncRational(a, 1) + *b*;
>
> It's weird this isn't caught in our unit tests (unless this is not
> specifically tested for yet).

It's weird that this isn't caught by the *compiler* -- isn't an unused
parameter a warning/error?

-derek

-- 
       Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
       Member, MIT Student Information Processing Board  (SIPB)
       URL: http://web.mit.edu/warlord/    PP-ASEL-IA     N1NWH
       warlord at MIT.EDU                        PGP key available