Robert Fewell 14ubobit at
Sat Jul 8 09:17:45 EDT 2017


That sounds like a good idea, not sure about the location, may be in
Some kind of naming format will need to be decided that makes sense.

I can have a look at that after all your initial thoughts !!


On 8 July 2017 at 14:01, Geert Janssens <geert.gnucash at> wrote:

> Bob,
> While reading through your changes I note we have lots of places where we
> make
> some small tweaks to the default gui style. It shows in your commits
> because
> we have to change from GtkStyle api to GtkStyleContext/GtkCssProvider api.
> This got me thinking about a future streamlining we should consider:
> instead
> of adding code snippets that insert custom CSS, can't we collect all of
> these
> snippets in one big CSS file we ship with gnucash, to be stored in /etc/
> gnucash/gnucash.css and which we read at load time ? Much like we now load
> a
> custom .gtk3.0-gnucash.css file.
> Both can co-exist IMO, with the latter taking precedence over the former.
> The
> one in etc should be "Application" priority the one in the homedir "User"
> priority.
> This would keep the code cleaner and separate function from presentation.
> Especially your initial work of adding style context to most widgets is a
> big
> step in the right direction.
> What do you think ?
> Regards,
> Geert
> On donderdag 29 juni 2017 11:16:04 CEST Robert Fewell wrote:
> > This is what I have done so far, may of gone too far but every thing
> still
> > appears to be working.
> > I have not touched any Aquabanking stuff, not sure what needs to be done
> to
> > get that enabled but probably would not take long to convert.
> >
> > All glade files are now verified against 3.10 and deprecated widgets
> > changed.
> > Stock buttons changed to the equivalent labels and images changed to
> icons
> > including the GNC_ ones.
> >
> > All deprecated widgets have been changed to 3.10 equivalents apart from
> > GtkUiManager, GtkAction and GtkActionMenu. These are mostly to do with
> > toolbars, menus, accelerator keys and there are no easy real equivalents
> so
> > propose to leave them deprecated to the end and then maybe a decision can
> > be made.
> >
> > I have tried to stay away from the register but some of the commits have
> > replaced some deprecated widgets.
> >
> > I have experimented with some CSS by adding style context classes of the
> > nature "GncImapDialog" to various dialogues and this seems to work quite
> > well down to changing the background colour of different tree views. May
> > continue to add more.
> >
> > There are no doubt some tweaks to be made to align with current version
> but
> > maybe that should wait till the gtk3 branch is updated from master.
> >
> > With version 3.22, I am getting warnings on the console about transient
> > windows not having a parent so may have a look at that next. There are
> > other warnings but they seem to be concerned with GTK itself, may need
> > looking at, not sure. Also with this version we get a whole new set of
> > deprecated widgets that may be an idea to get replaced. Will need to do a
> > complete rebuild on this version to get an updated log file.
> >
> >
> > Bob

More information about the gnucash-devel mailing list