[GNC-dev] [Gnucash/gnucash-docs] Adding reconciliation to glossary (#110)
sunfish62 at yahoo.com
Fri Aug 24 12:13:46 EDT 2018
I went ahead and closed the PR.
First problem: once I closed the PR, I could not locate the changes I made; there doesn’t appear to be a way to locate those changes. Did Github delete them altogether? Oh, wait. I see the changes in the Closed PR section, although I don’t know how I leverage that.
In this case, the change was pretty simple, so I just recreated it from scratch (I probably would be much crankier if the changes were more substantial!). I went to my fork, (re) added my changes, clicked the Commit and create PR option. I named the branch bug-791169 and gave the commit the name “Bug 791169 - Adding Reconciliation definition to Glossary” [BTW, github tells me that making my commit name longer than 50 characters shows me to be the amateur I am].
Now, I have a PR against my own fork. I would rather issue the PR against Gnucash/gnucash-docs, but don’t see how to get there.
Kinks in the hose!
> On Aug 24, 2018, at 11:08 AM, Geert Janssens <notifications at github.com <mailto:notifications at github.com>> wrote:
> Thanks David to run the experiment of working directly on github.
> That allows me to write my review there as well :)
> I have two remarks:
> We generally ask "commits" to reference the bug they fix if there is one. I see you have chosen to reference the bug in your branch name instead. The best way to do this is to use the bug and bug title as commit title (the first field in the "Commit changes" frame on the edit page).
> Any further clarifications or comments can be added in the second field.
> Your PR is crossing branches. That is, you created your commit starting from the maint branch (good, as this change is useful for gnucash 3.x and up) and then created a PR against master. That should be avoided.
> So even though the github interface is cleaner a minimal understanding of git branches is still needed when unsing the integrated editor. This is in no way meant to comment on your effort. Rather I'm using your experiment to draw conclusions and discover pitfalls.
> Do you want to continue the experiment and see if you can correct this ?
> I don't think you can change the commit message unless you redo the commit. You don't have to, I'll do so when pulling your PR.
> However you can test how hard you feel it is to fix the PR to be against the proper branch. If you want to, the way to do so is to close this PR, go back to your "Bug-791169---Add-Reconciliation-definition" branch and create a new PR, this time against the maint branch.
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <https://github.com/Gnucash/gnucash-docs/pull/110#issuecomment-415788314>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKdKdUFJFhndWYw8BKIfeqvH6Al1nBKGks5uUBbZgaJpZM4WKvKZ>.
More information about the gnucash-devel