[GNC-dev] Need help - several tests fail

[Geert Janssens]

Op zondag 25 augustus 2019 17:43:31 CEST schreef John Ralls:
> > On Aug 25, 2019, at 3:39 AM, Christian Gruber <christian.gruber at posteo.de>
> > wrote:> 
> > Am 22.08.19 um 09:21 schrieb Geert Janssens:
> >> Op donderdag 22 augustus 2019 05:37:12 CEST schreef John Ralls:
> >>>> On Aug 21, 2019, at 3:28 PM, Christian Gruber
> >>>> <christian.gruber at posteo.de>
> >>>> wrote:
> >>>> 
> >>>> Ok, that was a useful hint. Clearing the guile cache helped. I'm one
> >>>> step
> >>>> further. I have no idea, what led to this situation. I couldn't
> >>>> reproduce
> >>>> this again.
> >>>> 
> >>>> Next problem is that still several tests fail with the following
> >>>> output:
> >>>> 
> >>>> ERROR: no code for module (gnucash engine test srfi64-extras)
> >>> 
> >>> Which means that they're not finding
> >>> libgnucash/engine/test/srfi64-extras.scm or perhaps srfi64-extras.go Can
> >>> you figure out why? It might help to run make with VERBOSE=1 so that the
> >>> whole command is printed for each step or to switch to ninja which dumps
> >>> any failed commands without being asked and is also about 10x faster
> >>> than
> >>> make.
> >>> 
> >>> Regards,
> >>> John Ralls
> >> 
> >> It can also be an as of yet undiscovered build dependency issue (there
> >> still are a few on maint).
> >> 
> >> You didn't post any error output (or full build log) so it's hard to
> >> tell.
> >> In the build logs do you find a message logging the build of engine/test/
> >> srfi64-extras.go before you get your errors ?
> >> 
> >> Geert
> > 
> > I fixed the problem. It is a missing build dependency. I did only call
> > "make check" directly after generating a fresh build dir with CMake. So
> > not every dependency of the tests has been built yet, scm-srfi64-extras
> > is one of them. After calling "make all" and then "make check" again and
> > after installing missing french locale, all tests run successfully now.
> > Maybe there are even more missing dependencies, which are all built with
> > "make all".
> > 
> > Is this a known issue, that the test applications are missing some
> > required dependencies in the CMakeLists.txt? I'll have a look, what is
> > actually missing and try to fix it.
> We know that the dependency tree in the CMakeLists isn't exhaustive, but
> Geert had the check target sorted last winter. The srfi64 tests were added
> after that and I guess that some dependencies got missed then. Obviously
> having a full dependency tree is more robust, especially if the source
> directory layout changes so have at it!
> 
> Regards,
> John Ralls

IIRC I ran into this before and fixed it on master while reorganizing the 
scheme sources recently. As the file changes in that restructuring were fairly 
big, I didn't attempt to backport useful bits to maint. And I can't reproduce 
this particular dependency issue on master any more (just ran into a new one 
though).

So it may be a maint-only issue.

Geert