[GNC-dev] gnucash maint: Multiple changes pushed

[Geert Janssens]

Op dinsdag 26 februari 2019 11:24:26 CET schreef Christopher Lam:
> Updated	 via  https://github.com/Gnucash/gnucash/commit/d980bb50 (commit)
> 	 via  https://github.com/Gnucash/gnucash/commit/0ce6999f (commit)
> 	 via  https://github.com/Gnucash/gnucash/commit/5cdc5158 (commit)
> 	from  https://github.com/Gnucash/gnucash/commit/316a22a2 (commit)
> 
> 
> 
> commit d980bb50f7353a16cc4d144be89b140e55eab1d6
> Author: Christopher Lam <christopher.lck at gmail.com>
> Date:   Tue Feb 26 14:00:15 2019 +0800
> 
>     [report] display gnc-error-dialog only when UI is running
> 
>     This is preparation work for creating report.scm tests.
> 
> diff --git a/gnucash/report/report-system/report.scm
> b/gnucash/report/report-system/report.scm index 017dcd347..bace494d6 100644
> --- a/gnucash/report/report-system/report.scm
> +++ b/gnucash/report/report-system/report.scm
> @@ -398,8 +398,10 @@
>          )
>          report-id
>        )
> -      (begin
> -	(gnc-error-dialog '() (string-append "Report Failed! One of your
> previously opened reports has failed to open. The template on which it was
> based: " template-name ", was not found.")) +      (let ((errmsg
> (string-append "Report Failed! One of your previously opened reports has
> failed to open. The template on which it was based: " template-name ", was
> not found."))) +	(if (gnucash-ui-is-running)
> +            (gnc-error-dialog '() errmsg)
> +            (gnc:warn errmsg))
>  	#f))
>    )

Any reason why you didn't replace gnc-error-dialog with gnc:gui-error instead 
of adding these conditionals ?

Regards,
Geert