[GNC-dev] Enabling github branch protection rules? Re: [Gnucash/gnucash] po/de.po: fix translation bug (#627)

John Ralls jralls at ceridwen.us
Thu Jan 2 18:15:02 EST 2020


Just tried it as a test (the user id is code-gnucash-user). It doesn't prevent merging from the web page.

John Ralls

> On Jan 2, 2020, at 1:11 PM, Christian Stimming <christian at cstimming.de> wrote:
> Dear developers,
> yesterday I accidentally used the web interface of github to merge a pull 
> request, but we don't want this, because the merge (or any other commit) on 
> github is going to be overwritten by the next push from code.gnucash.org. 
> I was wondering whether we could enable the github "Protect matching branches" 
> rules 
> https://github.com/Gnucash/gnucash/settings/branch_protection_rules/new
> There's a rule "Restrict who can push to matching branches", which we could 
> restrict to the user that pushes from code.gnucash.org. This should prevent 
> any such accidental merges from github's web interface, shouldn't it? However, 
> this needs to be enabled by somebody who immediately can check that the push 
> from code still works. Anybody there care to take a look? Thanks a lot!
> Regards,
> Christian
> Am Donnerstag, 2. Januar 2020, 11:42:12 CET schrieb Frank H. Ellenberger:
>> Never use githubs webinterface for merging for any gnucash project!
>> Because code.gnucash.org is canonical, the merge got overwritten by the next
>> push.
> _______________________________________________
> gnucash-devel mailing list
> gnucash-devel at gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel

More information about the gnucash-devel mailing list