[GNC-dev] Adding a button to abort scrub?

[Christopher Lam]

PR 748 already works well in handling Escape in register scrub, report
building and rendering. The progress bar is augmented by adding state:
inactive, active non cancelable, active & cancelable, active & cancelling.

The idea to add a stop button next to the progress bar is sound, and its
visibility would depend on the cancelable status.

On Thu, 10 Sep 2020, 11:38 pm jean laroche, <ripngo at gmail.com> wrote:

> > The downside is that it's not terribly discoverable. What can we do to
> make it more so?
>
> I agree, but I don't know how to make the ESC obvious.
>
> > It would be nice to put it in the progress-bar code so that it is
> available by default for all processes that use the progress bar. Check &
> Repair isn't used much but there are plenty of reports that take awhile on
> a large book and it would be nice to be able to stop the report generating
> so one can get to the options dialog and set up the report one really wants.
>
> I thought of that: add an abort button that's handled like the progress
> bar in the code (it's a mess, but it would be easy to duplicate) and can
> be used in all situations where the progress bar is used. I can take a
> look at that. But there might be more pressing things to fix, no?
> Jean
> >> On Sep 9, 2020, at 9:46 AM, Jean Laroche <ripngo at gmail.com> wrote:
> >>
> >> Wow, that's super nice!
> >> J.
> >>
> >> On 9/9/20 9:43 AM, Christopher Lam wrote:
> >>> See the first commit in https://github.com/Gnucash/gnucash/pull/784
> -- with it you can abort scrub simply by pressing Escape.
> >>> On Thu, 10 Sep 2020, 12:19 am jean laroche, <ripngo at gmail.com <mailto:
> ripngo at gmail.com>> wrote:
> >>>     Christopher Lam suggested that the scrubbing process should be
> >>>     cancellable via a button (for context, we recently fixed a bug that
> >>>     could cause a crash when quitting GC during a scrub operation).
> >>>     I took a look at the code and as usual, it's not as easy as I would
> >>>     have
> >>>     hoped: the backend part (making the scrub stop) is very easy, as
> the
> >>>     abort mechanism is already in place. Adding an abort button in the
> >>>     right
> >>>     place on the relevant windows isn't as easy (see for example how
> the
> >>>     progress bar is created/handled, it's fairly convoluted to say the
> >>>     least).
> >>>     Two questions:
> >>>     - Do we really think it's worth the effort given how often
> scrubbing is
> >>>     used, and given that scrubbing only takes long on accounts with
> many
> >>>     transactions or books with many accounts?
> >>>     - If we think it's worth the effort, does one of you devs know how
> to
> >>>     easily add the abort button on the main window (and probably the
> >>>     account
> >>>     transactions window as well)? If so, we could split the task: you
> could
> >>>     add the right window, and I'd take it from there.
> >>>     Personally I doubt it's worth the effort...
> >>>     Jean
> >>>     _______________________________________________
> >>>     gnucash-devel mailing list
> >>>     gnucash-devel at gnucash.org <mailto:gnucash-devel at gnucash.org>
> >>>     https://lists.gnucash.org/mailman/listinfo/gnucash-devel
> >> _______________________________________________
> >> gnucash-devel mailing list
> >> gnucash-devel at gnucash.org
> >> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
> >
>